Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal from OWNERS #6218

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Removal from OWNERS #6218

merged 1 commit into from
Oct 13, 2022

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Oct 12, 2022

Removal from OWNERS

What type of PR is this:

/kind cleanup

What does this PR do / why we need it:

No longer reviewing / approving the project.

Thanks all for the wonderful years working on odo!

Which issue(s) this PR fixes:

N/A

Signed-off-by: Charlie Drage charlie@charliedrage.com

@cdrage
Removal from OWNERS
007d078 
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind feature
/kind tests
/kind documentation

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->
/kind cleanup

**What does this PR do / why we need it:**

No longer reviewing / approving the project.

Thanks all for the wonderful years working on `odo`!

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

N/A

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2022

@cdrage: The label(s) kind/cleanup cannot be applied, because the repository doesn't have them.

In response to this:

Removal from OWNERS

What type of PR is this:

/kind cleanup

What does this PR do / why we need it:

No longer reviewing / approving the project.

Thanks all for the wonderful years working on odo!

Which issue(s) this PR fixes:

N/A

Signed-off-by: Charlie Drage charlie@charliedrage.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Oct 12, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 007d078
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6346d9a82cf2a0000918846e
😎 Deploy Preview https://deploy-preview-6218--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot requested review from feloy and valaparthvi October 12, 2022 15:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@odo-robot
Copy link

odo-robot bot commented Oct 12, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 12, 2022

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 12, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 12, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 12, 2022

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Oct 13, 2022

Thanks @cdrage for all your work on odo
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 13, 2022
@valaparthvi
Copy link
Contributor

/approve
This is a sad PR :/
But, thank you for all your contributions, Charlie!

@openshift-ci
Copy link

openshift-ci bot commented Oct 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: valaparthvi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 13, 2022
@openshift-merge-robot openshift-merge-robot merged commit 1ad9347 into redhat-developer:main Oct 13, 2022
@rm3l
Copy link
Member

rm3l commented Oct 13, 2022 •
edited
Loading

Thanks @cdrage for your work on odo!

@dharmit
Copy link
Member

dharmit commented Oct 13, 2022

Thanks for your contributions @cdrage! It was a pleasure. 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy Awaiting requested review from feloy

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@feloy feloy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cdrage @feloy @valaparthvi @rm3l @dharmit @openshift-merge-robot