Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploymentExists different from component running #6048

Merged
merged 5 commits into from
Aug 24, 2022
Merged

deploymentExists different from component running #6048

merged 5 commits into from
Aug 24, 2022

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Aug 23, 2022

What type of PR is this:

/kind bug

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6022

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 23, 2022
@netlify
Copy link

netlify bot commented Aug 23, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 10a9486
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63060c787788110009f60d00

@feloy feloy changed the title deploymentExists different from component running [WIP] deploymentExists different from component running Aug 23, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 23, 2022
@openshift-ci openshift-ci bot requested review from cdrage and valaparthvi August 23, 2022 15:45
@odo-robot
Copy link

odo-robot bot commented Aug 23, 2022 •
edited
Loading

Unit Tests on commit 24a73bc finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 23, 2022 •
edited
Loading

OpenShift Tests on commit 24a73bc finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 23, 2022 •
edited
Loading

Validate Tests on commit 24a73bc finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 23, 2022 •
edited
Loading

Kubernetes Tests on commit 24a73bc finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the bugfix-6022/hotReloadCapable branch from f5ce436 to c394486 Compare August 23, 2022 16:27
@feloy feloy force-pushed the bugfix-6022/hotReloadCapable branch from c394486 to 4a69e26 Compare August 23, 2022 16:54
@feloy feloy changed the title [WIP] deploymentExists different from component running deploymentExists different from component running Aug 23, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 23, 2022
@feloy feloy force-pushed the bugfix-6022/hotReloadCapable branch from 58f882f to 781d175 Compare August 24, 2022 09:54
@feloy feloy closed this Aug 24, 2022
@feloy feloy reopened this Aug 24, 2022
valaparthvi
valaparthvi suggested changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@valaparthvi valaparthvi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use the community starter project for testing instead of adding the whole project? Looking at the test case, it seems unnecessary to me.

My bad, it is the community starter project.

@feloy @valaparthvi
Update tests/integration/cmd_dev_test.go
bcc466a 
Co-authored-by: Parthvi Vala <pvala@redhat.com>
@valaparthvi
Copy link
Contributor

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: valaparthvi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 24, 2022
@feloy @valaparthvi
Update pkg/devfile/adapters/kubernetes/component/adapter.go
5860499 
Co-authored-by: Parthvi Vala <pvala@redhat.com>
@valaparthvi
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 24, 2022
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 24, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Aug 24, 2022

Windows Tests (OCP) on commit ca9dff3 finished with errors.
View logs: TXT HTML

@valaparthvi
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 24, 2022
@openshift-merge-robot openshift-merge-robot merged commit 27f9dff into redhat-developer:main Aug 24, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
@feloy @valaparthvi @cdrage
deploymentExists different from component running (redhat-developer#6048
f2fe5f2 
)

* deploymentExists different from component running

* Add integration test

* Update tests/integration/cmd_dev_test.go

Co-authored-by: Parthvi Vala <pvala@redhat.com>

* Update pkg/devfile/adapters/kubernetes/component/adapter.go

Co-authored-by: Parthvi Vala <pvala@redhat.com>

* Fix fmt

Co-authored-by: Parthvi Vala <pvala@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valaparthvi valaparthvi valaparthvi requested changes

@cdrage cdrage Awaiting requested review from cdrage

Assignees

@valaparthvi valaparthvi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odo is not executing run command on java-quarkus devfile
3 participants
@feloy @valaparthvi @openshift-merge-robot