-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Troubleshoot IBM Cloud Windows tests failing #6038
Merged
openshift-merge-robot
merged 1 commit into
redhat-developer:main
from
feloy:fix-windows-tests
Aug 19, 2022
Merged
Troubleshoot IBM Cloud Windows tests failing #6038
openshift-merge-robot
merged 1 commit into
redhat-developer:main
from
feloy:fix-windows-tests
Aug 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
3c63d21
to
178a679
Compare
30cd678
to
d89bf56
Compare
82bb9f6
to
aa072da
Compare
aa072da
to
4582287
Compare
Kudos, SonarCloud Quality Gate passed! |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anandrkskd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 tasks
cdrage
pushed a commit
to cdrage/odo
that referenced
this pull request
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, when sending the Ctrl-C signal to the
odo dev
process to stop it, we firt need to set a specific attribute on the process (CREATE_NEW_PROCESS_GROUP
), or the parent process will also receive the signal.By changing from
CmdRunner()
toCmd().Runner()
in commit (224069c),setSysProcAttr
inCmdRunner()
is not called anymore.