Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Troubleshoot IBM Cloud Windows tests failing #6038

Merged

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Aug 18, 2022

On Windows, when sending the Ctrl-C signal to the odo dev process to stop it, we firt need to set a specific attribute on the process (CREATE_NEW_PROCESS_GROUP), or the parent process will also receive the signal.

By changing from CmdRunner() to Cmd().Runner() in commit (224069c), setSysProcAttr in CmdRunner() is not called anymore.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 18, 2022
@openshift-ci openshift-ci bot requested review from dharmit and valaparthvi August 18, 2022 15:02
@netlify
Copy link

netlify bot commented Aug 18, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 4582287
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62ff4c49ca684b0009b272d7

@odo-robot
Copy link

odo-robot bot commented Aug 18, 2022

Windows Tests (OCP) on commit cb3c2bb finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 18, 2022

Unit Tests on commit cb3c2bb finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 18, 2022

Validate Tests on commit cb3c2bb finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 18, 2022

Kubernetes Tests on commit cb3c2bb finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 18, 2022

OpenShift Tests on commit cb3c2bb finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the fix-windows-tests branch 8 times, most recently from 3c63d21 to 178a679 Compare August 18, 2022 17:55
@feloy feloy changed the title [WIP] Disable interactive tests to check if IBM Cloud Windows tests pass [WIP] Troubleshoot IBM Cloud Windows tests failing Aug 18, 2022
@feloy feloy force-pushed the fix-windows-tests branch 2 times, most recently from 30cd678 to d89bf56 Compare August 19, 2022 07:18
@feloy feloy closed this Aug 19, 2022
@feloy feloy reopened this Aug 19, 2022
@feloy feloy force-pushed the fix-windows-tests branch from 82bb9f6 to aa072da Compare August 19, 2022 07:56
@feloy feloy force-pushed the fix-windows-tests branch from aa072da to 4582287 Compare August 19, 2022 08:39
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@feloy feloy requested review from anandrkskd and removed request for dharmit August 19, 2022 08:50
@feloy feloy changed the title [WIP] Troubleshoot IBM Cloud Windows tests failing Troubleshoot IBM Cloud Windows tests failing Aug 19, 2022
@feloy feloy removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 19, 2022
@anandrkskd
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented Aug 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anandrkskd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 19, 2022
@openshift-merge-robot openshift-merge-robot merged commit 79a57cd into redhat-developer:main Aug 19, 2022
@feloy feloy mentioned this pull request Aug 22, 2022
3 tasks
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants