Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how odo works with projects/namespaces #6009

Merged

Conversation

valaparthvi
Copy link
Contributor

What type of PR is this:
/area documentation
/kind documentation

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #5860

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the area/documentation Issues or PRs related to documentation or the 'odo.dev' website label Aug 5, 2022
@netlify
Copy link

netlify bot commented Aug 5, 2022

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit d0793e5
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62f0e58684989e0009660088
😎 Deploy Preview https://deploy-preview-6009--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odo-robot
Copy link

odo-robot bot commented Aug 5, 2022

Unit Tests on commit c45487d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 5, 2022

Windows Tests (OCP) on commit c45487d finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 5, 2022

Kubernetes Tests on commit c45487d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 5, 2022

Validate Tests on commit c45487d finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Aug 5, 2022

OpenShift Tests on commit c45487d finished with errors.
View logs: TXT HTML

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could a note in the "odo dev" docs that documents that odo currently records the current namespace/project the first time it runs. And that changing it, for now, requires deleting the .odo folder.

Also, I think we should also update the docs for the "delete namespace/project" command, and mention that deletion does not change the namespace of the component either.

@valaparthvi valaparthvi requested a review from rm3l August 8, 2022 10:29
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 8, 2022
@valaparthvi
Copy link
Contributor Author

/override OpenShift Integration tests/OpenShift Integration tests
/override ci/prow/v4.10-integration-e2e
/override windows-integration-test/Windows-test

Unrelated failures related to cmd_logs_test.

@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2022

@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift Integration tests/OpenShift Integration tests, ci/prow/v4.10-integration-e2e, windows-integration-test/Windows-test

In response to this:

/override OpenShift Integration tests/OpenShift Integration tests
/override ci/prow/v4.10-integration-e2e
/override windows-integration-test/Windows-test

Unrelated failures related to cmd_logs_test.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented Aug 10, 2022

Very helpful doc, as I'm never sure myself about these points. Thanks

/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 10, 2022
@openshift-merge-robot openshift-merge-robot merged commit c384f54 into redhat-developer:main Aug 10, 2022
feloy added a commit to feloy/odo that referenced this pull request Aug 18, 2022
cdrage pushed a commit to cdrage/odo that referenced this pull request Aug 31, 2022
* Document how odo works with projects/namespaces

* rm3l's review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/documentation Issues or PRs related to documentation or the 'odo.dev' website lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how odo works with projects/namespaces
4 participants