update quickstart #5992

kadel · 2022-07-29T16:00:10Z

What type of PR is this:
/kind documentation

What does this PR do / why we need it:

This addresses some of the feedback that we got from running the pilot testing party.

adds information about required to login to the OpenShift cluster first
adds information about creating new namespace before creating an application on the cluster
adds option to create Route for OpenShift instead of Ingress

netlify · 2022-07-29T16:00:24Z

✅ Deploy Preview for odo-docusaurus-preview ready!

Name	Link
🔨 Latest commit	`31c4f9a`
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/62e7e6a8ff09e90008d5ceab
😎 Deploy Preview	https://deploy-preview-5992--odo-docusaurus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

odo-robot · 2022-07-29T16:07:26Z

Unit Tests on commit 501add2 finished successfully.
View logs: TXT HTML

odo-robot · 2022-07-29T16:15:45Z

Validate Tests on commit 501add2 finished successfully.
View logs: TXT HTML

odo-robot · 2022-07-29T16:16:56Z

Windows Tests (OCP) on commit 501add2 finished successfully.
View logs: TXT HTML

odo-robot · 2022-07-31T20:35:49Z

Kubernetes Tests on commit 501add2 finished successfully.
View logs: TXT HTML

odo-robot · 2022-07-31T21:29:47Z

OpenShift Tests on commit 501add2 finished with errors.
View logs: TXT HTML

docs/website/docs/user-guides/quickstart.md

Co-authored-by: Dharmit Shah <shahdharmit@gmail.com>

dharmit · 2022-08-01T13:51:02Z

/lgtm

docs/website/docs/user-guides/quickstart.md

Co-authored-by: Philippe Martin <contact@elol.fr>

feloy · 2022-08-01T14:15:22Z

/approve

openshift-ci · 2022-08-01T14:15:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~docs/OWNERS~~ [feloy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rm3l

LGTM after the changes already requested, but I had one last comment ^^

In "Step 4 (odo deploy)", it is currently written:

Your application has now been deployed to the Kubernetes cluster with Deployment, Service, and Ingress resources.

Test your application by visiting the DOMAIN_NAME variable that you had set in the devfile.yaml.

This seems relevant for Kubernetes only, since we are deploying a Route in Openshift. So maybe we should also have separate tabs for Kubernetes and Openshift, indicating how to access the application..

kadel · 2022-08-01T14:26:14Z

This seems relevant for Kubernetes only, since we are deploying a Route in Openshift. So maybe we should also have separate tabs for Kubernetes and Openshift, indicating how to access the application..

good catch. I'll change it

rm3l · 2022-08-01T14:29:32Z

This seems relevant for Kubernetes only, since we are deploying a Route in Openshift. So maybe we should also have separate tabs for Kubernetes and Openshift, indicating how to access the application..

good catch. I'll change it

/hold

(Just to make sure the PR does not get merged before those changes are pushed)

kadel · 2022-08-01T14:33:34Z

@rm3l new commit added. This also nicely highlights why we need #5990

docs/website/docs/user-guides/quickstart.md

rm3l · 2022-08-01T14:39:33Z

This also nicely highlights why we need #5990

Indeed. This would be helpful.

Co-authored-by: Armel Soro <armel@rm3l.org>

sonarqubecloud · 2022-08-01T14:44:30Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.3% Duplication

cdrage · 2022-08-01T14:46:02Z

docs/website/docs/user-guides/quickstart.md

+  </TabItem>
+  <TabItem value="openshift" label="OpenShift">
+
+### Login to OpenShift Cluster


maybe put this in a different tab and show kubernetes 1st? we want to try to remain Kubernetes #1 and show that first, especially with CNCF presentations / advertising / etc.

I'm not sure I understand this. The Kubernetes is always the first tab, and the OpenShift is the second. Or did I miss it somewhere?

Ah, I missed that part. I shouldn't be doing reviews on my day off, woops! When I went to preview it I hadn't seen it

kadel · 2022-08-01T17:32:44Z

/override OpenShift Integration tests/OpenShift Integration tests

openshift-ci · 2022-08-01T17:32:47Z

@kadel: Overrode contexts on behalf of kadel: OpenShift Integration tests/OpenShift Integration tests

In response to this:

/override OpenShift Integration tests/OpenShift Integration tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

* update quickstart * Update docs/website/docs/user-guides/quickstart.md Co-authored-by: Dharmit Shah <shahdharmit@gmail.com> * Update docs/website/docs/user-guides/quickstart.md Co-authored-by: Dharmit Shah <shahdharmit@gmail.com> * Update docs/website/docs/user-guides/quickstart.md Co-authored-by: Dharmit Shah <shahdharmit@gmail.com> * Update docs/website/docs/user-guides/quickstart.md Co-authored-by: Dharmit Shah <shahdharmit@gmail.com> * Update docs/website/docs/user-guides/quickstart.md Co-authored-by: Philippe Martin <contact@elol.fr> * Update docs/website/docs/user-guides/quickstart.md Co-authored-by: Philippe Martin <contact@elol.fr> * Update docs/website/docs/user-guides/quickstart.md Co-authored-by: Philippe Martin <contact@elol.fr> * Update docs/website/docs/user-guides/quickstart.md Co-authored-by: Philippe Martin <contact@elol.fr> * Update docs/website/docs/user-guides/quickstart.md Co-authored-by: Philippe Martin <contact@elol.fr> * Update docs/website/docs/user-guides/quickstart.md Co-authored-by: Philippe Martin <contact@elol.fr> * Update docs/website/docs/user-guides/quickstart.md Co-authored-by: Philippe Martin <contact@elol.fr> * Update docs/website/docs/user-guides/quickstart.md Co-authored-by: Philippe Martin <contact@elol.fr> * Update docs/website/docs/user-guides/quickstart.md Co-authored-by: Philippe Martin <contact@elol.fr> * Update docs/website/docs/user-guides/quickstart.md Co-authored-by: Philippe Martin <contact@elol.fr> * add info about how to get url * Update docs/website/docs/user-guides/quickstart.md Co-authored-by: Armel Soro <armel@rm3l.org> Co-authored-by: Dharmit Shah <shahdharmit@gmail.com> Co-authored-by: Philippe Martin <contact@elol.fr> Co-authored-by: Armel Soro <armel@rm3l.org>

update quickstart

a85265c

openshift-ci bot added the kind/documentation label Jul 29, 2022

kadel requested a review from cdrage July 29, 2022 16:00

openshift-ci bot requested review from dharmit and feloy July 29, 2022 16:00

dharmit suggested changes Aug 1, 2022

View reviewed changes

openshift-ci bot assigned dharmit Aug 1, 2022

kadel and others added 4 commits August 1, 2022 14:00

Update docs/website/docs/user-guides/quickstart.md

08f3234

Co-authored-by: Dharmit Shah <shahdharmit@gmail.com>

Update docs/website/docs/user-guides/quickstart.md

af1563d

Co-authored-by: Dharmit Shah <shahdharmit@gmail.com>

Update docs/website/docs/user-guides/quickstart.md

705b6ab

Co-authored-by: Dharmit Shah <shahdharmit@gmail.com>

Update docs/website/docs/user-guides/quickstart.md

4a86e95

Co-authored-by: Dharmit Shah <shahdharmit@gmail.com>

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 1, 2022

feloy reviewed Aug 1, 2022

View reviewed changes

Update docs/website/docs/user-guides/quickstart.md

16aff88

Co-authored-by: Philippe Martin <contact@elol.fr>

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 1, 2022

kadel and others added 8 commits August 1, 2022 16:09

Update docs/website/docs/user-guides/quickstart.md

051777b

Co-authored-by: Philippe Martin <contact@elol.fr>

Update docs/website/docs/user-guides/quickstart.md

e38d9b1

Co-authored-by: Philippe Martin <contact@elol.fr>

Update docs/website/docs/user-guides/quickstart.md

0b7c172

Co-authored-by: Philippe Martin <contact@elol.fr>

Update docs/website/docs/user-guides/quickstart.md

f288084

Co-authored-by: Philippe Martin <contact@elol.fr>

Update docs/website/docs/user-guides/quickstart.md

5ca2e8f

Co-authored-by: Philippe Martin <contact@elol.fr>

Update docs/website/docs/user-guides/quickstart.md

d3c7ba3

Co-authored-by: Philippe Martin <contact@elol.fr>

Update docs/website/docs/user-guides/quickstart.md

c9b5a39

Co-authored-by: Philippe Martin <contact@elol.fr>

Update docs/website/docs/user-guides/quickstart.md

b6d6c8f

Co-authored-by: Philippe Martin <contact@elol.fr>

Update docs/website/docs/user-guides/quickstart.md

d2d05d1

Co-authored-by: Philippe Martin <contact@elol.fr>

feloy approved these changes Aug 1, 2022

View reviewed changes

openshift-ci bot assigned feloy Aug 1, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 1, 2022

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 1, 2022

rm3l reviewed Aug 1, 2022

View reviewed changes

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Aug 1, 2022

add info about how to get url

807e873

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 1, 2022

rm3l requested changes Aug 1, 2022

View reviewed changes

docs/website/docs/user-guides/quickstart.md Outdated Show resolved Hide resolved

openshift-ci bot assigned rm3l Aug 1, 2022

Update docs/website/docs/user-guides/quickstart.md

31c4f9a

Co-authored-by: Armel Soro <armel@rm3l.org>

rm3l approved these changes Aug 1, 2022

View reviewed changes

cdrage reviewed Aug 1, 2022

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 1, 2022

rm3l removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Aug 1, 2022

openshift-merge-robot merged commit 854e756 into redhat-developer:main Aug 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update quickstart #5992

update quickstart #5992

kadel commented Jul 29, 2022

netlify bot commented Jul 29, 2022 •

edited

Loading

odo-robot bot commented Jul 29, 2022 •

edited

Loading

odo-robot bot commented Jul 29, 2022 •

edited

Loading

odo-robot bot commented Jul 29, 2022 •

edited

Loading

odo-robot bot commented Jul 31, 2022 •

edited

Loading

odo-robot bot commented Jul 31, 2022 •

edited

Loading

dharmit commented Aug 1, 2022

feloy commented Aug 1, 2022

openshift-ci bot commented Aug 1, 2022

rm3l left a comment

kadel commented Aug 1, 2022

rm3l commented Aug 1, 2022

kadel commented Aug 1, 2022

rm3l commented Aug 1, 2022

sonarqubecloud bot commented Aug 1, 2022

cdrage Aug 1, 2022

kadel Aug 1, 2022

cdrage Aug 2, 2022

kadel commented Aug 1, 2022

openshift-ci bot commented Aug 1, 2022

update quickstart #5992

update quickstart #5992

Conversation

kadel commented Jul 29, 2022

netlify bot commented Jul 29, 2022 • edited Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

odo-robot bot commented Jul 29, 2022 • edited Loading

odo-robot bot commented Jul 29, 2022 • edited Loading

odo-robot bot commented Jul 29, 2022 • edited Loading

odo-robot bot commented Jul 31, 2022 • edited Loading

odo-robot bot commented Jul 31, 2022 • edited Loading

dharmit commented Aug 1, 2022

feloy commented Aug 1, 2022

openshift-ci bot commented Aug 1, 2022

rm3l left a comment

Choose a reason for hiding this comment

kadel commented Aug 1, 2022

rm3l commented Aug 1, 2022

kadel commented Aug 1, 2022

rm3l commented Aug 1, 2022

sonarqubecloud bot commented Aug 1, 2022

cdrage Aug 1, 2022

Choose a reason for hiding this comment

kadel Aug 1, 2022

Choose a reason for hiding this comment

cdrage Aug 2, 2022

Choose a reason for hiding this comment

kadel commented Aug 1, 2022

openshift-ci bot commented Aug 1, 2022

netlify bot commented Jul 29, 2022 •

edited

Loading

odo-robot bot commented Jul 29, 2022 •

edited

Loading

odo-robot bot commented Jul 29, 2022 •

edited

Loading

odo-robot bot commented Jul 29, 2022 •

edited

Loading

odo-robot bot commented Jul 31, 2022 •

edited

Loading

odo-robot bot commented Jul 31, 2022 •

edited

Loading