odo dev: handle port forwarding after pod restart #5885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
4a43631 to
2c4fd9d
Compare
dharmit
suggested changes
Jun 28, 2022
261ebc9 to
6c4416f
Compare
|
@feloy the message about port-forwarding is appearing quite early: |
7c20ce3 to
e7bc96f
Compare
|
/lgtm |
|
/lgtm |
… devfile.yaml changes
edc703e to
8bc71a6
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
rm3l
reviewed
Jul 4, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/override ci/prow/v4.10-integration-e2e |
|
@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.10-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cdrage
pushed a commit
to cdrage/odo
that referenced
this pull request
Aug 31, 2022
) * Move port forwarding to reconcile loop * Add integration test * Fix dependencies on cli/dev + remove message to restart odo dev after devfile.yaml changes * Restart port forwarding when endpoints are modified in Devfile * Fix setNamespace * Fix componentName * Move message back to CLI * add doc * Move port forwarding after starting application * Remove unnecessary dependency to State module * Fix err
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind feature
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #5866
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: