Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

having no components in an app shouldn't be an error #1919

Conversation

girishramnani
Copy link
Contributor

What is the purpose of this change? What does it change?

having no components in an app shouldn't be an error

Was the change discussed in an issue?

fixes #1803

How to test changes?

odo app describe test --project myproject > out 2>error

check out file, now it should have the Application test has no components or services deployed. message

@girishramnani
Copy link
Contributor Author

/retest

@girishramnani
Copy link
Contributor Author

/test unit

@girishramnani
Copy link
Contributor Author

/retest

@girishramnani girishramnani requested a review from cdrage July 18, 2019 14:20
Copy link
Member

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues with the code and 👍 to tests being re-enabled.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 18, 2019
Copy link
Contributor

@surajnarwade surajnarwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: surajnarwade

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Jul 19, 2019
@amitkrout
Copy link
Contributor

#1832
/test integration

@openshift-merge-robot openshift-merge-robot merged commit 724a139 into redhat-developer:master Jul 19, 2019
@rm3l rm3l added the estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. estimated-size/XS (1-5) Rough sizing for Epics. Less than one sprint of work for one person, but smaller than S. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency in odo command exit code
7 participants