-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
having no components in an app shouldn't be an error #1919
having no components in an app shouldn't be an error #1919
Conversation
/retest |
/test unit |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues with the code and 👍 to tests being re-enabled.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: surajnarwade The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#1832 |
What is the purpose of this change? What does it change?
having no components in an app shouldn't be an error
Was the change discussed in an issue?
fixes #1803
How to test changes?
check
out
file, now it should have theApplication test has no components or services deployed.
message