Adds `odo create project -o json` output #1916

cdrage · 2019-07-17T19:56:29Z

Adds machine readable output for odo create project.

To test:

odo create project -o json

cdrage · 2019-07-17T19:57:14Z

/hold

This is WIP as well as builds on the #1898 branch..

cdrage · 2019-07-19T20:01:53Z

/retest

cdrage · 2019-08-02T16:56:51Z

/hold cancel

mik-dass · 2019-08-05T09:24:53Z

on Travis

✓  Waiting for project to come up [445ms]
✓  Project 'vvpzytcnxg' is ready for use
I0802 21:26:24.072718   18053 cmdutils.go:26] Error:
unable to set current project tovvpzytcnxg: unable to switch to vvpzytcnxg project: yaml: line 8: could not find expected ':'
✗  yaml: line 8: could not find expected ':'
Deleting project: 
Running odo with args [odo project delete  -f]
✗  Error loading config file "/home/travis/.kube/config": yaml: line 8: could not find expected ':'
 Please login to your server: 
837

On openshift CI


    Expected '' should be valid JSON, but it is not.
      
    Underlying error:unexpected end of JSON input
     /go/src/github.com/openshift/odo/tests/integration/json_test.go:49

/retest

mik-dass · 2019-08-06T06:39:28Z

Running odo with args [odo app delete app -f]
[odo]  ✗  invalid configuration: [context was not found for specified context: anbdgyfyxu/api-ci-op-dy725ykj-f09f4-origin-ci-int-aws-dev-rhcloud-com:6443/developer, cluster has no server defined]

/retest

mik-dass · 2019-08-06T09:27:12Z

✗  invalid configuration: [context was not found for specified context: anbdgyfyxu/api-ci-op-dy725ykj-f09f4-origin-ci-int-aws-dev-rhcloud-com:6443/developer, cluster has no server defined]

/retest

girishramnani · 2019-08-14T11:31:13Z

pkg/odo/cli/project/create.go

+
+	// If -o json has been passed, let's output the approriate json output!
+	if log.IsJSON() {
+		project.MachineReadableSuccessOutput(pco.projectName, successMessage)


Nit: this is a bit confusing as it feels that function is not breaking and the next line would get executed

Got it :) Added an else statement.

girishramnani · 2019-08-14T11:31:52Z

Other than what others have commented I have one nitpick

girishramnani · 2019-08-14T11:32:02Z

/approve

openshift-ci-robot · 2019-08-14T11:32:15Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: girishramnani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [girishramnani]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mik-dass

/lgtm from me

/hold please have a look at @dharmit comments

cdrage · 2019-08-15T21:07:16Z

Could you have another quick look @dharmit ? Thanks for the updates!

dharmit · 2019-08-20T10:32:28Z

@cdrage I still see:

$ odo project create -w newproject -o json | jq .
parse error: Invalid numeric literal at line 1, column 5

is this expected? #1916 (comment) makes me believe that you tried to fix this.

cdrage · 2019-08-20T19:12:19Z

I'll investigate it again @dharmit for some reason, it is only being affected when using the --wait / -w command..

dharmit · 2019-08-21T05:34:23Z

I'll investigate it again @dharmit for some reason, it is only being affected when using the --wait / -w command..

Are you going to do it as a part of this PR or create a separate issue to track it? I was told that latter would be helpful in unblocking #1960. We can cancel the hold in that case.

cdrage · 2019-08-21T14:36:48Z

Just updated the PR again to fix your issue. Seems like a spinner was still being shown @dharmit

cdrage · 2019-08-21T15:00:20Z

/retest all

Adds machine readable output for odo create project. To test: ```sh odo create project -o json ```

dharmit · 2019-08-22T04:57:28Z

Works like a charm

$ odo project create -w newproject -o json | jq .
{
  "kind": "Project",
  "apiVersion": "odo.openshift.io/v1alpha1",
  "metadata": {
    "name": "newproject",
    "namespace": "newproject",
    "creationTimestamp": null
  },
  "message": "Project 'newproject' is ready for use"
}

Thanks @cdrage!

/hold cancel

cdrage · 2019-08-22T13:41:31Z

/retest

dharmit · 2019-08-22T13:42:24Z

/lgtm

openshift-bot · 2019-08-22T15:31:54Z

/retest

Please review the full test history for this PR and help us cut down flakes.

cdrage · 2019-08-22T16:46:22Z

Looks like it's stick in limbo on testing...

/retest all

openshift-ci-robot requested review from girishramnani and mik-dass July 17, 2019 19:56

openshift-ci-robot added the size/L label Jul 17, 2019

cdrage mentioned this pull request Jul 17, 2019

Add machine readable output for odo project create #1854

Closed

cdrage added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 17, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jul 17, 2019

cdrage force-pushed the add-create-project branch 3 times, most recently from 048d279 to 4fea5cb Compare July 19, 2019 19:31

cdrage force-pushed the add-create-project branch 5 times, most recently from d2c998b to ab68796 Compare July 29, 2019 15:48

cdrage mentioned this pull request Jul 29, 2019

Add odo project delete -o json #1960

Closed

cdrage force-pushed the add-create-project branch from ab68796 to 105b9d9 Compare July 30, 2019 18:16

cdrage mentioned this pull request Jul 30, 2019

Review JSON output for all odo commands #1739

Closed

2 tasks

cdrage removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Aug 2, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Aug 2, 2019

cdrage force-pushed the add-create-project branch 4 times, most recently from ee0a080 to 40de901 Compare August 2, 2019 21:15

cdrage force-pushed the add-create-project branch from 40de901 to f2b3af5 Compare August 6, 2019 17:37

girishramnani reviewed Aug 14, 2019

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Aug 14, 2019

mik-dass approved these changes Aug 14, 2019

View reviewed changes

cdrage force-pushed the add-create-project branch 3 times, most recently from 9c9f18e to 080d774 Compare August 15, 2019 21:07

cdrage force-pushed the add-create-project branch from 080d774 to 0d4696e Compare August 21, 2019 14:05

Adds odo create project -o json output

b444527

Adds machine readable output for odo create project. To test: ```sh odo create project -o json ```

cdrage force-pushed the add-create-project branch from 0d4696e to b444527 Compare August 21, 2019 20:05

dharmit approved these changes Aug 22, 2019

View reviewed changes

openshift-ci-robot assigned dharmit Aug 22, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Aug 22, 2019

openshift-merge-robot merged commit 387145f into redhat-developer:master Aug 22, 2019

cdrage deleted the add-create-project branch January 14, 2022 14:50

rm3l added estimated-size/L (20-40) Rough sizing for Epics. About 2 sprints of work for a person. and removed size/L labels Jun 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds `odo create project -o json` output #1916

Adds `odo create project -o json` output #1916

cdrage commented Jul 17, 2019

cdrage commented Jul 17, 2019

cdrage commented Jul 19, 2019

cdrage commented Aug 2, 2019

mik-dass commented Aug 5, 2019

mik-dass commented Aug 6, 2019

mik-dass commented Aug 6, 2019

girishramnani Aug 14, 2019

cdrage Aug 15, 2019

girishramnani commented Aug 14, 2019 •

edited

Loading

girishramnani commented Aug 14, 2019

openshift-ci-robot commented Aug 14, 2019

mik-dass left a comment •

edited

Loading

cdrage commented Aug 15, 2019

dharmit commented Aug 20, 2019

cdrage commented Aug 20, 2019 •

edited

Loading

dharmit commented Aug 21, 2019

cdrage commented Aug 21, 2019

cdrage commented Aug 21, 2019

dharmit commented Aug 22, 2019

cdrage commented Aug 22, 2019

dharmit commented Aug 22, 2019

openshift-bot commented Aug 22, 2019

cdrage commented Aug 22, 2019

Adds odo create project -o json output #1916

Adds odo create project -o json output #1916

Conversation

cdrage commented Jul 17, 2019

cdrage commented Jul 17, 2019

cdrage commented Jul 19, 2019

cdrage commented Aug 2, 2019

mik-dass commented Aug 5, 2019

mik-dass commented Aug 6, 2019

mik-dass commented Aug 6, 2019

girishramnani Aug 14, 2019

Choose a reason for hiding this comment

cdrage Aug 15, 2019

Choose a reason for hiding this comment

girishramnani commented Aug 14, 2019 • edited Loading

girishramnani commented Aug 14, 2019

openshift-ci-robot commented Aug 14, 2019

mik-dass left a comment • edited Loading

Choose a reason for hiding this comment

cdrage commented Aug 15, 2019

dharmit commented Aug 20, 2019

cdrage commented Aug 20, 2019 • edited Loading

dharmit commented Aug 21, 2019

cdrage commented Aug 21, 2019

cdrage commented Aug 21, 2019

dharmit commented Aug 22, 2019

cdrage commented Aug 22, 2019

dharmit commented Aug 22, 2019

openshift-bot commented Aug 22, 2019

cdrage commented Aug 22, 2019

Adds `odo create project -o json` output #1916

Adds `odo create project -o json` output #1916

girishramnani commented Aug 14, 2019 •

edited

Loading

mik-dass left a comment •

edited

Loading

cdrage commented Aug 20, 2019 •

edited

Loading