-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running spec parallelly for clean test template #1759
Changes from all commits
b786ab7
a3ba01d
1798471
25c7950
0e2d63f
e9c8a8f
901da3e
6b393bc
16e6e27
321b091
9ce7698
3fc64bf
beb9aa7
02148e6
48c65e1
713af19
fe082b9
3d060da
d86f667
72d334f
e596a11
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,7 +9,9 @@ export CI="openshift" | |
export TIMEOUT="30m" | ||
make configure-installer-tests-cluster | ||
make bin | ||
export PATH="$PATH:$(pwd)" | ||
mkdir -p $GOPATH/bin | ||
go get -u github.com/onsi/ginkgo/ginkgo | ||
export PATH="$PATH:$(pwd):$GOPATH/bin" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why adding There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was in beginning when the script was created, so i could not analyze the intention of keeping it. Anyway i do not see any valid reason to keep it. Will remove it There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, sorry. I haven't noticed that it was there before. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. $(pwd) is needed in the PATH as we are not copying odo to /usr/bin |
||
export CUSTOM_HOMEDIR="/tmp/artifacts" | ||
make test-generic | ||
make test-odo-login-e2e | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds it to just OpenShift-CI. It won't be needed on travis?
We have
make goget-tools
that should be used for this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
Done - https://github.com/openshift/odo/pull/1759/files#diff-b67911656ef5d18c4ae36cb6741b7965R69