Skip to content

Commit

Permalink
Update doc
Browse files Browse the repository at this point in the history
  • Loading branch information
feloy committed May 24, 2023
1 parent 0cf37da commit e9c739b
Showing 1 changed file with 5 additions and 23 deletions.
28 changes: 5 additions & 23 deletions docs/proposals/commands-semantic.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Components:

| Command | PreStart | PostStart | PreStop | PostStop |
|-----------------------------|----------|-----------|---------|-----------|
| exec on container | | Y(1) | Y(1) | |
| exec on container | | Y | Y | |
| exec on cluster resource | N/A | N/A | N/A | N/A |
| exec on volume | N/A | N/A | N/A | N/A |
| exec on image | N/A | N/A | N/A | N/A |
Expand All @@ -24,15 +24,15 @@ Components:

| Command | Build | Run/Debug | Deploy |
|-----------------------------|-------|-----------|--------|
| exec on container | Y(1) | Y(2) | Y(3) |
| exec on container | Y | Y | Y |
| exec on cluster resource | N/A | N/A | N/A |
| exec on volume | N/A | N/A | N/A |
| exec on image | N/A | N/A | N/A |
|   | | | |
| apply on container | ? | ? | ? |
| apply on cluster resource | 0 | Y(2) | Y(3) |
| apply on cluster resource | 0 | Y | Y |
| apply on volume | ? | ? | ? |
| apply on image | 0 | Y(2) | Y(3) |
| apply on image | 0 | Y | Y |
|   | | | |
| composite serial | | | |
| composite parallel | | | |
Expand All @@ -41,24 +41,6 @@ Components:
Legend:

- 0: Supported by handler but not implemented
- Y: Implemented
- Y: Implemented by pkg/component.NewRunHandler
- N/A: Not applicable (by spec)
- ?: Spec is not clear

- (1) Implemented by pkg/component.NewExecHandler
- ApplyImage -> nil
- ApplyKubernetes -> nil
- ApplyOpenShift -> nil
- Execute -> (specific, calling execClient.ExecuteCommand on existing component)

- (2) Implemented by pkg/dev/kubedev.runHandler / pkg.dev/podmandev.commandHandler
- ApplyImage -> image.BuildPushSpecificImage / image.BuildPushSpecificImage
- ApplyKubernetes -> component.ApplyKubernetes / nil (not possible)
- ApplyOpenShift -> component.ApplyKubernetes / nil (not possible)
- Execute -> component.ExecuteRunCommand / component.ExecuteRunCommand

- (3) Implemented by pkg/deploy.deployHandler
- ApplyImage -> image.BuildPushSpecificImage
- ApplyKubernetes -> component.ApplyKubernetes
- ApplyOpenShift -> component.ApplyKubernetes
- Execute -> (specific, creating a job)

0 comments on commit e9c739b

Please sign in to comment.