Skip to content

Commit

Permalink
fix flake
Browse files Browse the repository at this point in the history
Signed-off-by: anandrkskd <anandrkskd@gmail.com>
  • Loading branch information
anandrkskd committed Aug 8, 2022
1 parent 4c266a6 commit 262bff9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ export ODO_LOG_LEVEL ?= 4
# To enable verbosity export or set env GINKGO_TEST_ARGS like "GINKGO_TEST_ARGS=-v"
UNIT_TEST_ARGS ?=

export ARTIFACT_DIR ?= .

GINKGO_FLAGS_ALL = $(GINKGO_TEST_ARGS) --randomize-all --slow-spec-threshold=$(SLOW_SPEC_THRESHOLD) -timeout $(TIMEOUT) --no-color

# Flags for tests that must not be run in parallel.
Expand Down
1 change: 0 additions & 1 deletion scripts/openshiftci-presubmit-all-tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,4 @@ else
fi
fi


oc logout
6 changes: 2 additions & 4 deletions tests/integration/interactive_add_binding_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -224,13 +224,12 @@ var _ = Describe("odo add binding interactive command tests", func() {
var nsWithNoService string

BeforeEach(func() {
nsWithNoService = commonVar.Project
otherNS = commonVar.CliRunner.CreateAndSetRandNamespaceProject()
addBindableKindInOtherNs := commonVar.CliRunner.Run("-n", otherNS, "apply", "-f",
helper.GetExamplePath("manifests", "bindablekind-instance.yaml"))
Expect(addBindableKindInOtherNs.ExitCode()).To(BeEquivalentTo(0))

nsWithNoService = commonVar.CliRunner.CreateAndSetRandNamespaceProject()

commonVar.CliRunner.SetProject(commonVar.Project)
})

Expand Down Expand Up @@ -555,13 +554,12 @@ var _ = Describe("odo add binding interactive command tests", func() {
var nsWithNoService string

BeforeEach(func() {
nsWithNoService = commonVar.Project
otherNS = commonVar.CliRunner.CreateAndSetRandNamespaceProject()
addBindableKindInOtherNs := commonVar.CliRunner.Run("-n", otherNS, "apply", "-f",
helper.GetExamplePath("manifests", "bindablekind-instance.yaml"))
Expect(addBindableKindInOtherNs.ExitCode()).To(BeEquivalentTo(0))

nsWithNoService = commonVar.CliRunner.CreateAndSetRandNamespaceProject()

commonVar.CliRunner.SetProject(commonVar.Project)
})

Expand Down

0 comments on commit 262bff9

Please sign in to comment.