Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit variable substitution #96

Merged

Conversation

feloy
Copy link
Collaborator

@feloy feloy commented Nov 19, 2021

Fixes the following error visible in the container when workingDir in devfile is using a variable:

ls: cannot access '${PROJECTS_ROOT}': No such file or directory

@openshift-ci openshift-ci bot requested review from dharmit and prietyc123 November 19, 2021 10:45
Copy link
Contributor

@anandrkskd anandrkskd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2021
@feloy
Copy link
Collaborator Author

feloy commented Nov 22, 2021

/approve

1 similar comment
@kadel
Copy link
Member

kadel commented Nov 22, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy, kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2021
@openshift-merge-robot openshift-merge-robot merged commit b84ad84 into redhat-developer:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants