-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up naming supervisord-image -> init-image #29
Clean up naming supervisord-image -> init-image #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mohammedzee1000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kadel Make sure that travis CI should pass |
It won't pass as it requires changes in redhat-developer/odo#2027. And tests for redhat-developer/odo#2027 won't pass without this :-D Chicken and Egg problem. The less evil is to merge this first, as it won't break any existing code on odo side. |
I don't see any issue with this. Let's coordinate a time to merge all three in at the same time. |
/lgtm |
@kadel: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This image contains more than supervisord, this updates naming and paths to be more generic to reflect current use.
/opt/odo-init/
instead of/opt/supervisord
inside the initContainer image/opt/odo
instead of/var/lib/supervisord
insde the builder container