Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up naming supervisord-image -> init-image #29

Merged

Conversation

kadel
Copy link
Member

@kadel kadel commented Aug 20, 2019

This image contains more than supervisord, this updates naming and paths to be more generic to reflect current use.

  • clean up some unnecessary lines from Dockerfile
  • use /opt/odo-init/ instead of /opt/supervisord inside the initContainer image
  • use /opt/odo instead of /var/lib/supervisord insde the builder container

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 20, 2019
Copy link
Collaborator

@mohammedzee1000 mohammedzee1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good
/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mohammedzee1000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2019
@amitkrout
Copy link
Contributor

@amitkrout
Copy link
Contributor

Ping @girishramnani @mohammedzee1000 @cdrage

@kadel Make sure that travis CI should pass

@kadel
Copy link
Member Author

kadel commented Aug 27, 2019

@kadel Make sure that travis CI should pass

It won't pass as it requires changes in redhat-developer/odo#2027. And tests for redhat-developer/odo#2027 won't pass without this :-D Chicken and Egg problem.

The less evil is to merge this first, as it won't break any existing code on odo side.

@cdrage
Copy link
Member

cdrage commented Aug 27, 2019

I don't see any issue with this. Let's coordinate a time to merge all three in at the same time.

@kadel
Copy link
Member Author

kadel commented Aug 28, 2019

/lgtm

@openshift-ci-robot
Copy link

@kadel: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kadel kadel added the lgtm Indicates that a PR is ready to be merged. label Aug 28, 2019
@openshift-merge-robot openshift-merge-robot merged commit a3afbfd into redhat-developer:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants