Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go image from registry.access.redhat.io #100

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

feloy
Copy link
Collaborator

@feloy feloy commented Dec 1, 2021

To help the build on brew during the release process of this image, we need an image both accessible from brew (limited to redhat registries) and from unauthenticated users that would like to build this image from github.

@feloy feloy requested review from kadel and removed request for mohammedzee1000 December 1, 2021 08:35
@kadel
Copy link
Member

kadel commented Dec 6, 2021

/approave
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2021
@kadel
Copy link
Member

kadel commented Dec 6, 2021

/approve

@openshift-ci
Copy link

openshift-ci bot commented Dec 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2021
@kadel kadel merged commit bd964e6 into redhat-developer:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants