Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial packages for Java SDK #4

Merged
merged 3 commits into from
Jun 9, 2021

Conversation

secondsun
Copy link
Contributor

No description provided.

@wtrocki
Copy link
Collaborator

wtrocki commented Jun 4, 2021

@secondsun

Let's:

@secondsun secondsun force-pushed the initial branch 2 times, most recently from 019d9cf to c099a7c Compare June 4, 2021 19:26
commit-message: "chore: generate API client"
author: "app-services-ci <app-services-ci@users.noreply.github.com>"
delete-branch: true
reviewers: craicoverflow, wtrocki
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add yourself

# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions

name: Release Script
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly you can remove this one

.gitignore Outdated
@@ -0,0 +1,122 @@
# Logs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace with one from operator repo

@@ -0,0 +1,10 @@
## Authentication for Instance SDK's
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw.. I have fixed docs on sdk-js. Copy again :D

@wtrocki
Copy link
Collaborator

wtrocki commented Jun 4, 2021

Amazing. Left initial comments. You have my blessing to rebase this to master

@wtrocki
Copy link
Collaborator

wtrocki commented Jun 8, 2021

Maybe we can merge this and do micro changes from now on.
Obviously please resolve my initial comments :D

@wtrocki wtrocki changed the title feat: initial work in progress [DO NOT MERGE] feat: initial packages for Java SDK Jun 9, 2021
@secondsun secondsun merged commit 209d7f4 into redhat-developer:main Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants