Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: now using core sdk #1813

Merged
merged 2 commits into from
Feb 22, 2023
Merged

feat: now using core sdk #1813

merged 2 commits into from
Feb 22, 2023

Conversation

jackdelahunt
Copy link
Contributor

Closes #

Verification Steps

  1. Do x
  2. Do y

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Other (please specify)

@rkpattnaik780
Copy link
Contributor

rkpattnaik780 commented Feb 21, 2023 •
edited
Loading

Looks great!
We can create a beta release from this branch and verify further with e2e tests.

@jackdelahunt
Copy link
Contributor Author

E2e tests passed 👍

@jackdelahunt jackdelahunt merged commit 63e0eba into main Feb 22, 2023
@jackdelahunt jackdelahunt deleted the new-go-sdk branch February 22, 2023 11:36
@wtrocki
Copy link
Collaborator

wtrocki commented Feb 22, 2023

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkpattnaik780 rkpattnaik780 rkpattnaik780 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackdelahunt @rkpattnaik780 @wtrocki