Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: override fetch if instance exists #1760

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Conversation

rkpattnaik780
Copy link
Contributor

Adresses #1522

Verification Steps

  1. Run Service Registry describe command in verbose mode:
rhoas service-registry describe -v
  1. It should call the endpoint api/serviceregistry_mgmt/v1/registries/<registry-id> only once.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation change
  • Optimization

@rkpattnaik780
Copy link
Contributor Author

This is the most straight forward method to ensure CLI doesnt end up doing multiple requests, marking this PR as draft for initial discussions, will replicate to rest of the commands once we lock on an approach.

@jackdelahunt jackdelahunt marked this pull request as ready for review February 21, 2023 11:48
@jackdelahunt jackdelahunt requested review from jackdelahunt and removed request for jackdelahunt February 21, 2023 11:49
@rkpattnaik780 rkpattnaik780 merged commit 28d9c88 into main Feb 22, 2023
@rkpattnaik780 rkpattnaik780 deleted the context_fetch branch February 22, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants