Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatcher configurable triggering #39

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

jacobsee
Copy link
Contributor

What does this PR do?

Add the ability to specify a configmap with a key that controls whether the dispatcher actually processes any tasks or not. Added to better facilitate use of blue/green environments.

How should this be tested?

Deploy an instance of the dispatcher with triggering disabled, observe that it does not do anything

Is there a relevant Issue open for this?

Other Relevant info, PRs, etc.

People to notify

cc: @redhat-cop/tool-integrations @oybed @pabrahamsson

…patcher actually processes any tasks or not.
Copy link
Contributor

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of inline comments

resource-dispatcher/documentation/deployment.md Outdated Show resolved Hide resolved
resource-dispatcher/system_management/__init__.py Outdated Show resolved Hide resolved
Copy link
Contributor

@oybed oybed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oybed oybed merged commit 4865c11 into redhat-cop:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants