Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitleaks config file and update git ignore list #270

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

branic
Copy link
Collaborator

@branic branic commented Feb 20, 2025

What does this PR do?

Adds the .ansible directory to the git ignore list. Running pre-commit is causing the .ansible directory to be created in the current working directory and automated PR creation such as update the pre-commit versions to include it in the git commit.

This caused Red Hat Infosec to raise a security leak as the kubernetes.core collection tests include passwords and/or tokens needed for tests.

In addition to adding the .ansible directory to the git ignore list this also include a gitleaks configuration file that will cause gitleaks to not raise a security violation for passwords and tokens in the .ansible/collections directory. This is being added at the request of the Red Hat Infosec team and the contents of the .gitleaks.toml file was provided by them.

How should this be tested?

N/A

Is there a relevant Issue open for this?

None

Other Relevant info, PRs, etc

See PRs #266 and #269 for example of where the .ansible directory was included in the automated update to the pre-commit configuration.

Copy link
Contributor

@djdanielsson djdanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djdanielsson djdanielsson merged commit e92dbd3 into redhat-cop:devel Feb 21, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants