Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gitops SCM authentication #461

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

Roming22
Copy link
Member

This was broken with 44728b5

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

This was broken with 44728b5

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
quay:
enabled: true
enabled: __OVERWRITE_ME__
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Alternatively we could make boolean fields false by default.

Copy link
Collaborator

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Feb 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: otaviof, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f6dbed1 into redhat-appstudio:main Feb 13, 2025
11 checks passed
@Roming22 Roming22 deleted the fix/gitops/auth branch February 13, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants