added Dockerfile #20
Merged
added Dockerfile #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xinredhat
commented
Jun 13, 2024
- Added a Dockerfile for running CI jobs
- Added yamllint.yaml
- Downgrade golang to 1.21
otaviof
reviewed
Jun 13, 2024
ci/config/yamllint.yaml
Outdated
There was a problem hiding this comment.
Could we move this file to the project root? So, when using yamllint outside of CI relies on the same configuration file?
There was a problem hiding this comment.
sure, then we move the both files yamlint.yaml and Dockerfile to the project root, WDYT?
There was a problem hiding this comment.
No, I won't move the Dockerfile to the project root, as it's only used for CI
otaviof
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.