Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #187

Merged
merged 3 commits into from
Aug 29, 2024
Merged

Conversation

raisavarghese
Copy link
Contributor

Added steps for integration and deploy of rhtap

Added steps for integration and deploy of rhtap
@openshift-ci openshift-ci bot requested review from flacatus and xinredhat August 27, 2024 10:27
Copy link

openshift-ci bot commented Aug 27, 2024

Hi @raisavarghese. Thanks for your PR.

I'm waiting for a redhat-appstudio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@raisavarghese
Copy link
Contributor Author

@jkopriva

@jkopriva
Copy link
Contributor

@raisavarghese Hi looks good!

@xinredhat
Copy link
Member

/ok-to-test

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@raisavarghese raisavarghese requested a review from otaviof August 28, 2024 05:35
Copy link
Collaborator

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a final change, but thanks for the docs!

README.md Outdated
Comment on lines 114 to 119
```yaml
redHatAdvancedClusterSecurity:
enabled: false

redHatQuay:
enabled: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please unindent this block.

Copy link

@raisavarghese raisavarghese requested a review from otaviof August 28, 2024 12:46
@openshift-ci openshift-ci bot added the lgtm label Aug 29, 2024
Copy link

openshift-ci bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: otaviof, raisavarghese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f8a5482 into redhat-appstudio:main Aug 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants