Update fault injection to use a single x-bp-fault header. #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
This PR consolidates all of the fault injection headers into one. This is necessary to allow multiple fault injection configurations on a single request.
📜 Details
DM me for the doc.
Note that this PR removes support for the original
x-bp-fault-headers. My understanding is that this is OK since this is a new unused feature. If backwards compatibility is required, however, let me know and I can update this to ensure the previous headers are still read as backups.🧪 Testing Steps / Validation
This was tested solely through comprehensive unit testing.
✅ Checks