always update thrift header write list in headerbp client middleware #685
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💸 TL;DR
This is really just to make the code cleaner since it technically works because
thrift.GetWriteHeaderList
returns the underlying list, not a copy, andslices.Delete
deletes from the source slice. I think the code is a lot clearer and less likely to have a bug later if we always set the outgoing header list.I verified this by adding a test case. The test passes without my changes, but it fails if I copy
outgoing
before deleting the headers from it.