Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecates redisbp for future version of baseplate.go #660

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −0
Draft

Deprecates redisbp for future version of baseplate.go #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c925e30
Deprecates redisbp for future version of baseplate.go
justinmir Aug 26, 2024
3b526f7
allow deprecated in test
justinmir Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions httpbp/example_server_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"github.com/reddit/baseplate.go/ecinterface"
"github.com/reddit/baseplate.go/httpbp"
"github.com/reddit/baseplate.go/log"
//lint:ignore SA1019 deprecated library can still be used for testing
"github.com/reddit/baseplate.go/redis/db/redisbp"
"github.com/reddit/baseplate.go/secrets"
)
Expand Down
6 changes: 6 additions & 0 deletions redis/db/redisbp/monitored_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
// Package redisbp creates baseplate monitored Redis clients with go-redis/v8.
// It supports only Redis <= 6.
//
// Deprecated: redisbp only supports only Redis 6. Use reddit-go/redisbp
// to support Redis 6+ clients. This package will not be supported in the
// future.
package redisbp

import (
Expand Down
Loading