Workaround a bug in envoy #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fishy
requested changes
Mar 30, 2022
fishy
reviewed
Mar 30, 2022
There was a problem hiding this comment.
the code lgtm, but before we can merge it:
- The PR title should be something like "Workaround a bug in envoy" as this is not a bug in baseplate.go
- We need to file a bug on envoy, and link the bug here, so we could revert this change in the future when the bug is fixed in envoy.
d6ee414 to
70458d0
Compare
kylelemons
requested changes
Mar 30, 2022
marcoferrer
commented
Mar 30, 2022
marcoferrer
commented
Mar 30, 2022
FranGM
pushed a commit
to FranGM/baseplate.go
that referenced
this pull request
Mar 31, 2022
This change was taken from reddit#500
marcoferrer
commented
Mar 31, 2022
fishy
approved these changes
Mar 31, 2022
kylelemons
approved these changes
Mar 31, 2022
pacejackson
approved these changes
Mar 31, 2022
|
you have extra trailing spaces: https://github.com/reddit/baseplate.go/runs/5775116141?check_suite_focus=true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to bring baseplate go in sync with baseplate py.