Skip to content

Commit

Permalink
Update for go 1.24
Browse files Browse the repository at this point in the history
- Update go.mod to require 1.23+
- Update CI to run on go 1.23 & 1.24
  • Loading branch information
fishy committed Feb 14, 2025
1 parent 9a3f681 commit 5d0471b
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/go-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ jobs:
strategy:
matrix:
go-version:
- "1.22"
- "1.23"
- "1.24"

container:
image: golang:${{ matrix.go-version }}
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/reddit/baseplate.go

go 1.22.0
go 1.23

require (
github.com/Shopify/sarama v1.29.1
Expand Down
1 change: 0 additions & 1 deletion internal/admin/server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ var expectedMetrics = []string{
"go_godebug_non_default_behavior_randautoseed_events_total",
"go_godebug_non_default_behavior_tarinsecurepath_events_total",
"go_godebug_non_default_behavior_tlsmaxrsasize_events_total",
"go_godebug_non_default_behavior_x509sha1_events_total",
"go_godebug_non_default_behavior_x509usefallbackroots_events_total",
"go_godebug_non_default_behavior_zipinsecurepath_events_total",
"go_goroutines",
Expand Down

0 comments on commit 5d0471b

Please sign in to comment.