-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Regex and full query for definition files with additional parameter mappings and output fields for SentinelOne #87
Conversation
Still working on a review of this but in the meantime, this is the test file I'm using for future reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplified the code a little bit to avoid using regex checks unless absolutely necessary.
I really like the expanded list of supported event fields - I haven't fully tested that portion but the column orders look good and the names make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
edit: going to go ahead and merge so we can update future branches with these changes and adjust code accordingly
Added Regex and full query for definition files with additional parameter mappings and output fields for SentinelOne
changes are only applied to the SentinelOne product in this PR.
Validation:
![query_testing_regex_full_query](https://user-images.githubusercontent.com/61033168/203602915-37de4cc9-ec9d-417c-9ee4-1840d5ed5dcd.png)
definition file containing full query options and regular definitions
successful output of definition file using regex and showing added fields in CSV
![csv_output](https://user-images.githubusercontent.com/61033168/203608460-9041a7c0-be7f-4ce3-b8ba-f8c8c5c903ca.png)
Resolves #85
Resolves #86