-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow SiteID and/or AccountID in CommandLine #79
Allow SiteID and/or AccountID in CommandLine #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the suggested changes, it would be nice to prevent site_ids from being added to the DV query if they reach a certain number. For example when trying to query an account with 50+ siteIds, the query can reach a maximum limitation in the API query.
I recommend line 449 be changed to check if the length is greater than 50 and if so, do not add the siteIds to the query.
remove brackets around self._account_ids Co-authored-by: xC0uNt3r7hr34t <61033168+xC0uNt3r7hr34t@users.noreply.github.com>
allow multiple account_ids in config file Co-authored-by: xC0uNt3r7hr34t <61033168+xC0uNt3r7hr34t@users.noreply.github.com>
allow multiple site_ids in config file Co-authored-by: xC0uNt3r7hr34t <61033168+xC0uNt3r7hr34t@users.noreply.github.com>
allow multiple account_names in config file Co-authored-by: xC0uNt3r7hr34t <61033168+xC0uNt3r7hr34t@users.noreply.github.com>
Co-authored-by: xC0uNt3r7hr34t <61033168+xC0uNt3r7hr34t@users.noreply.github.com>
Co-authored-by: xC0uNt3r7hr34t <61033168+xC0uNt3r7hr34t@users.noreply.github.com>
Co-authored-by: xC0uNt3r7hr34t <61033168+xC0uNt3r7hr34t@users.noreply.github.com>
Co-authored-by: xC0uNt3r7hr34t <61033168+xC0uNt3r7hr34t@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and verified siteID and accountID filtering works correctly. Ready to be merged.
…issue Allow SiteID and/or AccountID in CommandLine
Changes
/web/api/v2.1/agents/count
since API key validation naturally occurs in_get_site_ids()
Closes #75 and #76