Added base_query filters to merged queries for all command line argument scenarios #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 27, 2022 13:54
…ions and resolved double merges of base_query.
rc-csmith
suggested changes
Oct 4, 2022
There was a problem hiding this comment.
Both the _process_queries and get_results functions rely on the self._queries to build S1 searches. I would leave these functions as-is since they are standardized across EDR product files.
Since self._queries is defined in the function nested_process_search, I would recommend inject the filter options there. Per line #339 (or around that area), base_query is processed but is never used so it should just be a matter of adjusting how new entries into self._queries are created.
added 7 commits
October 4, 2022 16:13
rc-csmith
suggested changes
Oct 7, 2022
rc-csmith
approved these changes
Nov 3, 2022
xC0uNt3r7hr34t
pushed a commit
to xC0uNt3r7hr34t/surveyor
that referenced
this pull request
Jun 30, 2023
Added base_query filters to merged queries for all command line argument scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #77