Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix destroy KMS Vault #11222

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fix destroy KMS Vault #11222

merged 1 commit into from
Jan 24, 2025
+32 −16

Conversation

petr-balogh
Copy link
Member

No description provided.

@petr-balogh
Fix destroy KMS Vault
2bc4a71 
Signed-off-by: Petr Balogh <pbalogh@redhat.com>
@petr-balogh petr-balogh requested a review from a team as a code owner January 24, 2025 09:59
@pull-request-size pull-request-size bot added the size/M PR that changes 30-99 lines label Jan 24, 2025
shylesh
shylesh approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@shylesh shylesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 24, 2025
@petr-balogh
Copy link
Member Author

Verified here:
https://url.corp.redhat.com/91dc34b

2025-01-24 11:14:23  05:14:23 - MainThread - ocs_ci.utility.kms - INFO  - ['default', 'rook-63f6266d-4bb6-453f-bd85-5d1f4dee12ba-pakamble-418vs1']
2025-01-24 11:14:23  05:14:23 - MainThread - ocs_ci.utility.kms - INFO  - setting vault_policy_name = rook-63f6266d-4bb6-453f-bd85-5d1f4dee12ba-pakamble-418vs1
2025-01-24 11:14:24  05:14:24 - MainThread - ocs_ci.utility.kms - INFO  - Vault path ocs-63f6266d-4bb6-453f-bd85-5d1f4dee12ba-pakamble-418vs1 deleted
2025-01-24 11:14:25  05:14:25 - MainThread - ocs_ci.utility.kms - INFO  - Vault policy rook-63f6266d-4bb6-453f-bd85-5d1f4dee12ba-pakamble-418vs1 deleted
2025-01-24 11:14:26  05:14:26 - MainThread - ocs_ci.utility.kms - INFO  - Vault namespace ocs-namespace-63f6266d-4bb6-453f-bd85-5d1f4dee12ba-pakamble-418vs1 deleted

@petr-balogh petr-balogh added the Verified Mark when PR was verified and log provided label Jan 24, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dahorak, petr-balogh, shylesh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dahorak dahorak merged commit 9bf5e75 into red-hat-storage:master Jan 24, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dahorak dahorak dahorak approved these changes

@shylesh shylesh shylesh approved these changes

Assignees

@shylesh shylesh

@dahorak dahorak

Labels
lgtm size/M PR that changes 30-99 lines Verified Mark when PR was verified and log provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petr-balogh @shylesh @dahorak