Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFBUGS-1215: Non-linear parsing of case-insensitive content (CVE-2024-45338) #466

Merged
merged 1 commit into from
Feb 10, 2025
Merged

DFBUGS-1215: Non-linear parsing of case-insensitive content (CVE-2024-45338) #466

merged 1 commit into from
Feb 10, 2025

Conversation

black-dragon74
Copy link
Member

Update golang.org/x/net from 0.31.0 to 0.34.0

@black-dragon74
Copy link
Member Author

black-dragon74 commented Feb 10, 2025 •
edited
Loading

/hold Merge after: #464 (Will require rebase)

@black-dragon74 black-dragon74 changed the title Non-linear parsing of case-insensitive content (CVE-2024-45338) DFBUGS-1215: Non-linear parsing of case-insensitive content (CVE-2024-45338) Feb 10, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid jira ticket of any type jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting labels Feb 10, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2025 •
edited by openshift-ci bot
Loading

@black-dragon74: This pull request references [Jira Issue DFBUGS-1215](https://issues.redhat.com//browse/DFBUGS-1215), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

Update golang.org/x/net from 0.31.0 to 0.34.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 10, 2025 •
edited
Loading

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: nehaberry.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@black-dragon74: This pull request references [Jira Issue DFBUGS-1215](https://issues.redhat.com//browse/DFBUGS-1215), which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (odf-4.18) matches configured target version for branch (odf-4.18)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @nehaberry

In response to this:

Update golang.org/x/net from 0.31.0 to 0.34.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@black-dragon74
Copy link
Member Author

/cherry-pick release-4.17
/cherry-pick release-4.16
/cherry-pick release-4.15
/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@black-dragon74: once the present PR merges, I will cherry-pick it on top of release-4.14, release-4.15, release-4.16, release-4.17 in new PRs and assign them to you.

In response to this:

/cherry-pick release-4.17
/cherry-pick release-4.16
/cherry-pick release-4.15
/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@black-dragon74
rebase: CVE-2024-45338 Non-linear parsing of case-insensitive
c6e82b7 
content in golang.org/x/net/html

Update golang.org/x/net from 0.31.0 to 0.34.0

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
@black-dragon74
Copy link
Member Author

/hold cancel

Rakshith-R
Rakshith-R approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Code looks good label Feb 10, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: black-dragon74, Rakshith-R

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Feb 10, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit b7f9a20 into red-hat-storage:release-4.18 Feb 10, 2025
10 of 12 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 10, 2025 •
edited by openshift-ci bot
Loading

@black-dragon74: [Jira Issue DFBUGS-1215](https://issues.redhat.com//browse/DFBUGS-1215): All pull requests linked via external trackers have merged:

[Jira Issue DFBUGS-1215](https://issues.redhat.com//browse/DFBUGS-1215) has been moved to the MODIFIED state.

In response to this:

Update golang.org/x/net from 0.31.0 to 0.34.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@black-dragon74: #466 failed to apply on top of branch "release-4.17":

Applying: rebase: CVE-2024-45338 Non-linear parsing of case-insensitive
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
A	vendor/golang.org/x/net/http2/config.go
A	vendor/golang.org/x/net/http2/config_go124.go
M	vendor/golang.org/x/net/http2/http2.go
M	vendor/golang.org/x/net/http2/server.go
M	vendor/golang.org/x/net/http2/transport.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging vendor/golang.org/x/net/http2/transport.go
CONFLICT (content): Merge conflict in vendor/golang.org/x/net/http2/transport.go
Auto-merging vendor/golang.org/x/net/http2/server.go
CONFLICT (content): Merge conflict in vendor/golang.org/x/net/http2/server.go
Auto-merging vendor/golang.org/x/net/http2/http2.go
CONFLICT (modify/delete): vendor/golang.org/x/net/http2/config_go124.go deleted in HEAD and modified in rebase: CVE-2024-45338 Non-linear parsing of case-insensitive. Version rebase: CVE-2024-45338 Non-linear parsing of case-insensitive of vendor/golang.org/x/net/http2/config_go124.go left in tree.
CONFLICT (modify/delete): vendor/golang.org/x/net/http2/config.go deleted in HEAD and modified in rebase: CVE-2024-45338 Non-linear parsing of case-insensitive. Version rebase: CVE-2024-45338 Non-linear parsing of case-insensitive of vendor/golang.org/x/net/http2/config.go left in tree.
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 rebase: CVE-2024-45338 Non-linear parsing of case-insensitive

In response to this:

/cherry-pick release-4.17
/cherry-pick release-4.16
/cherry-pick release-4.15
/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@black-dragon74: #466 failed to apply on top of branch "release-4.16":

Applying: rebase: CVE-2024-45338 Non-linear parsing of case-insensitive
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
A	vendor/golang.org/x/net/http2/config.go
A	vendor/golang.org/x/net/http2/config_go124.go
M	vendor/golang.org/x/net/http2/frame.go
M	vendor/golang.org/x/net/http2/http2.go
M	vendor/golang.org/x/net/http2/server.go
M	vendor/golang.org/x/net/http2/transport.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging vendor/golang.org/x/net/http2/transport.go
CONFLICT (content): Merge conflict in vendor/golang.org/x/net/http2/transport.go
Auto-merging vendor/golang.org/x/net/http2/server.go
CONFLICT (content): Merge conflict in vendor/golang.org/x/net/http2/server.go
Auto-merging vendor/golang.org/x/net/http2/http2.go
Auto-merging vendor/golang.org/x/net/http2/frame.go
CONFLICT (modify/delete): vendor/golang.org/x/net/http2/config_go124.go deleted in HEAD and modified in rebase: CVE-2024-45338 Non-linear parsing of case-insensitive. Version rebase: CVE-2024-45338 Non-linear parsing of case-insensitive of vendor/golang.org/x/net/http2/config_go124.go left in tree.
CONFLICT (modify/delete): vendor/golang.org/x/net/http2/config.go deleted in HEAD and modified in rebase: CVE-2024-45338 Non-linear parsing of case-insensitive. Version rebase: CVE-2024-45338 Non-linear parsing of case-insensitive of vendor/golang.org/x/net/http2/config.go left in tree.
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 rebase: CVE-2024-45338 Non-linear parsing of case-insensitive

In response to this:

/cherry-pick release-4.17
/cherry-pick release-4.16
/cherry-pick release-4.15
/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@black-dragon74: #466 failed to apply on top of branch "release-4.15":

Applying: rebase: CVE-2024-45338 Non-linear parsing of case-insensitive
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
A	vendor/golang.org/x/net/http2/config.go
A	vendor/golang.org/x/net/http2/config_go124.go
M	vendor/golang.org/x/net/http2/frame.go
M	vendor/golang.org/x/net/http2/http2.go
M	vendor/golang.org/x/net/http2/server.go
M	vendor/golang.org/x/net/http2/transport.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging vendor/golang.org/x/net/http2/transport.go
CONFLICT (content): Merge conflict in vendor/golang.org/x/net/http2/transport.go
Auto-merging vendor/golang.org/x/net/http2/server.go
CONFLICT (content): Merge conflict in vendor/golang.org/x/net/http2/server.go
Auto-merging vendor/golang.org/x/net/http2/http2.go
Auto-merging vendor/golang.org/x/net/http2/frame.go
CONFLICT (modify/delete): vendor/golang.org/x/net/http2/config_go124.go deleted in HEAD and modified in rebase: CVE-2024-45338 Non-linear parsing of case-insensitive. Version rebase: CVE-2024-45338 Non-linear parsing of case-insensitive of vendor/golang.org/x/net/http2/config_go124.go left in tree.
CONFLICT (modify/delete): vendor/golang.org/x/net/http2/config.go deleted in HEAD and modified in rebase: CVE-2024-45338 Non-linear parsing of case-insensitive. Version rebase: CVE-2024-45338 Non-linear parsing of case-insensitive of vendor/golang.org/x/net/http2/config.go left in tree.
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 rebase: CVE-2024-45338 Non-linear parsing of case-insensitive

In response to this:

/cherry-pick release-4.17
/cherry-pick release-4.16
/cherry-pick release-4.15
/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@black-dragon74: #466 failed to apply on top of branch "release-4.14":

Applying: rebase: CVE-2024-45338 Non-linear parsing of case-insensitive
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
A	vendor/golang.org/x/net/http2/config.go
A	vendor/golang.org/x/net/http2/config_go124.go
M	vendor/golang.org/x/net/http2/frame.go
M	vendor/golang.org/x/net/http2/http2.go
M	vendor/golang.org/x/net/http2/server.go
M	vendor/golang.org/x/net/http2/transport.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging vendor/golang.org/x/net/http2/transport.go
CONFLICT (content): Merge conflict in vendor/golang.org/x/net/http2/transport.go
Auto-merging vendor/golang.org/x/net/http2/server.go
CONFLICT (content): Merge conflict in vendor/golang.org/x/net/http2/server.go
Auto-merging vendor/golang.org/x/net/http2/http2.go
Auto-merging vendor/golang.org/x/net/http2/frame.go
CONFLICT (modify/delete): vendor/golang.org/x/net/http2/config_go124.go deleted in HEAD and modified in rebase: CVE-2024-45338 Non-linear parsing of case-insensitive. Version rebase: CVE-2024-45338 Non-linear parsing of case-insensitive of vendor/golang.org/x/net/http2/config_go124.go left in tree.
CONFLICT (modify/delete): vendor/golang.org/x/net/http2/config.go deleted in HEAD and modified in rebase: CVE-2024-45338 Non-linear parsing of case-insensitive. Version rebase: CVE-2024-45338 Non-linear parsing of case-insensitive of vendor/golang.org/x/net/http2/config.go left in tree.
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 rebase: CVE-2024-45338 Non-linear parsing of case-insensitive

In response to this:

/cherry-pick release-4.17
/cherry-pick release-4.16
/cherry-pick release-4.15
/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@black-dragon74
Copy link
Member Author

/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link

@black-dragon74: #466 failed to apply on top of branch "release-4.17":

Applying: rebase: CVE-2024-45338 Non-linear parsing of case-insensitive
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
A	vendor/golang.org/x/net/http2/config.go
A	vendor/golang.org/x/net/http2/config_go124.go
M	vendor/golang.org/x/net/http2/http2.go
M	vendor/golang.org/x/net/http2/server.go
M	vendor/golang.org/x/net/http2/transport.go
M	vendor/modules.txt
Falling back to patching base and 3-way merge...
Auto-merging vendor/modules.txt
CONFLICT (content): Merge conflict in vendor/modules.txt
Auto-merging vendor/golang.org/x/net/http2/transport.go
CONFLICT (content): Merge conflict in vendor/golang.org/x/net/http2/transport.go
Auto-merging vendor/golang.org/x/net/http2/server.go
CONFLICT (content): Merge conflict in vendor/golang.org/x/net/http2/server.go
Auto-merging vendor/golang.org/x/net/http2/http2.go
CONFLICT (modify/delete): vendor/golang.org/x/net/http2/config_go124.go deleted in HEAD and modified in rebase: CVE-2024-45338 Non-linear parsing of case-insensitive. Version rebase: CVE-2024-45338 Non-linear parsing of case-insensitive of vendor/golang.org/x/net/http2/config_go124.go left in tree.
CONFLICT (modify/delete): vendor/golang.org/x/net/http2/config.go deleted in HEAD and modified in rebase: CVE-2024-45338 Non-linear parsing of case-insensitive. Version rebase: CVE-2024-45338 Non-linear parsing of case-insensitive of vendor/golang.org/x/net/http2/config.go left in tree.
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 rebase: CVE-2024-45338 Non-linear parsing of case-insensitive

In response to this:

/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees

@Rakshith-R Rakshith-R

Labels
approved Its a good idea jira/valid-bug Indicates that the referenced jira bug is valid for the branch this PR is targeting jira/valid-reference Indicates that this PR references a valid jira ticket of any type lgtm Code looks good
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@black-dragon74 @openshift-ci-robot @openshift-cherrypick-robot @Rakshith-R