chore(deps): update odh-kuberay-operator-controller-v2-16 to ccba472 #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: konflux-internal-p02 <123456+konflux-internal-p02[bot]@users.noreply.github.com>
konflux-internal-p02 bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
Add `make clean` which removes build artefacts. At the moment it's ./bin, ./odh-manifests/* and cover.out from test target. Do not remove odh-manifests directory since it is commited to VCS. In the recipe chown of $(LOCALBIN) since setup-envtest makes its dir RO for some reason [1]. Related: #696 [1] https://github.com/kubernetes-sigs/controller-runtime/blob/main/tools/setup-envtest/store/store.go#L191 Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
konflux-internal-p02 bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
It's a bit tedeous to supply IMG for barely every `make` call so make it contstructed by Makefile itself based on the current user. The default image name will be quay.io/$(USER)/opendatahub-operator:latest if USER environment variable is not empty. It's still possible to amend the generation with variables: IMAGE_OWNER - as before, uses value as quay.io space. IMG_TAG - use the tag instead of `latest`. The variable name is chosen because of IMG variable. IMG - as before, use the complete image name In the assignments '?=' replaced/used by '=' to not mess up with the environment by accident since the names are pretty generic (it's always possible to use `make -e` for those who wants). It should not make problems with CI since it uses the names directly [1] using our csv [2]. To push the image it uses workflow [3] (code [4]). Related: #696 [1] https://github.com/openshift/release/blob/master/ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-incubation.yaml#L24 [2] https://github.com/opendatahub-io/opendatahub-operator/blob/incubation/bundle/manifests/opendatahub-operator.clusterserviceversion.yaml#L1678 [3] https://github.com/openshift/release/blob/master/ci-operator/config/opendatahub-io/opendatahub-operator/opendatahub-io-opendatahub-operator-incubation.yaml#L47 [4] https://github.com/openshift/release/blob/master/ci-operator/step-registry/opendatahub-io/ci/image-mirror/opendatahub-io-ci-image-mirror-commands.sh Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
konflux-internal-p02 bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
- rename default target `all` to `default`. Sounds more appropriate since there are a lot of other jobs left. - depend `default` from `lint` and `unit-test` It looks like more appropriate default for developers. Related: #696 Signed-off-by: Yauheni Kaliuta <ykaliuta@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
08900a6->ccba472Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
To execute skipped test pipelines write comment
/ok-to-test