RHOAI-v2.8: Sync from upstream #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> Co-authored-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 0e9c4ed)
) * test: adds failing test to cover missconfigured tracker and cleanup logic * fix: ensures cleanup of associated FeatureTracker * chore(test): extracts secret creation to its own func * chore: uses addCleanup func (cherry picked from commit 55118bd)
* feat: enhances FeatureTracker with spec (#17) * initial add tracker spec * update tests, update crd * add omitempty to origin struct * undo accidental tag change * re add empty line * move pointer operator * add testing * lint * re-lint changes * add ownertype, move newOrigin() to shared util * Update apis/features/v1/features_types.go Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * remove origin from featureinitializer * modify kserve sm step to match dashboard's * make dsci servicemesh setup like dashboard's * fix merge issues, lint --------- Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> * restore testing mistakenly removed in merge * satisfy linter post merge conflicts * fix linter post merge * fix post merge issue * split For() into With + DefinedBy * rename origin to source, definedby to from --------- Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> (cherry picked from commit 591a291)
Co-authored-by: Bartosz Majsak <bartosz.majsak@gmail.com> (cherry picked from commit 3558db6)
…/RHOAIENG-2219 (opendatahub-io#817) (cherry picked from commit db3bf7b)
…pendatahub-io#814) This prevents KNative's net-istio pods from being OOMKilled in environments with a large number of Secrets. This would patch a Managed installation. Custom installations would be left untouched. Signed-off-by: Edgar Hernández <23639005+israel-hdez@users.noreply.github.com> (cherry picked from commit e1409af)
Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 92beb80)
…pendatahub-io#816) - this will be able to test live build if set devFlags on the Trustyai with downstream RHOAI build Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit f70e966)
- `FeaturesInitializer` (now named `FeaturesHandler`) becomes an entry point to compose features
- it has two modes: cluster and component. Based on this mode it will initialize `.spec.source` transparently
- there is no `Prepare` func anymore - it is now part of `Apply` and `Delete` - most importantly `FeaturesHandler` keeps track of created features so there is no need to keep adding to the slice explicitly
- Tests have been adjusted to focus on behavior rather than implementation details
(cherry picked from commit d6168fd)
(cherry picked from commit fec8a2b)
favoring fluent interface for readability instead of passing values after a closure passed to Eventually or Consistenly Gomega checks. (cherry picked from commit 312554d)
* add manual upgrade testing document (cherry picked from commit f2b177a)
Instead of using our random string generation, this PR relies on how k8s does it internally. See https://github.com/kubernetes/apimachinery/blob/f14778da5523847e4c07346e3161a4b4f6c9186e/pkg/util/rand/rand.go#L98 (cherry picked from commit 6530454)
`walkErr` is propagated as part of a recursive call when traversing a directory tree. This adds a guard check and does not proceed if the error happens in the call chain. Without this, the controller will `panic` in case of the wrong path defined for a manifest. (cherry picked from commit 052124e)
Missed as part of opendatahub-io#839. I assumed it is part of default target (cherry picked from commit d32bee5)
…pendatahub-io#846) This is based on the assumption that calling the `make` default target ensures the repo is always in the desired state. This includes: - all generated artifacts are up-to-date with the code they are derived from - code passes defined linter checks - a subset of tests (fast tests) is passing - no compilation errors (cherry picked from commit 69356d3)
* Fix: add back logic to deal with uninstallation - when CM exist and DSC CR exists Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: cleanup finalzlier * fix Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: uninstallation process - add logic to remove subscription - do not call backup in DSCI during uninstallation - add permisison of delete subscripton - change function SubscriptionExists() return sub Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: add deletion for DS project as well during uninstallation Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: add calls of component.Cleanup() esp for kserve for now for uninstall Signed-off-by: Wen Zhou <wenzhou@redhat.com> * revert: deletion ds project during uninstall Signed-off-by: Wen Zhou <wenzhou@redhat.com> * fix: extend timeout in unit-test till we update testcase Signed-off-by: Wen Zhou <wenzhou@redhat.com> * cleanup: remove commented block Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 9227687)
…ndatahub-io#850) Signed-off-by: Vedant Mahabaleshwarkar <vmahabal@redhat.com> (cherry picked from commit ae3b539)
(cherry picked from commit 4d8ba7e)
* Add odh-trusted-ca-bundle CM to DSCInitialization (cherry picked from commit 5d415c2) * Update ca bundle configMap to use dscInit TrustedCABundle for the default value (cherry picked from commit 9a94ef6) * Add Trusted Bundle Configmap to all namespaces * Add ManagementState to TrustedCABundle Co-authored-by: Wen Zhou <wenzhou@redhat.com> fix --------- Co-authored-by: Landon LaSmith <LLaSmith@redhat.com> (cherry picked from commit d998839)
- simplifies interaction with cluster APIs by using basic `client.Interface` only instead. - previously, for those CRDs we did not want to take as dependencies, `DynamicClient` was used. Now unstructured objects with GVK set instead are used with `client.Interface` instead. (cherry picked from commit 3fb7fd8)
Signed-off-by: Landon LaSmith <LLaSmith@redhat.com> Co-authored-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 6c038ce)
opendatahub-io#863) * feat(nwp): add ingress from cluster-monitoring to applicationnamespace Signed-off-by: Wen Zhou <wenzhou@redhat.com> * update: code review and clean NWP not needed for now Signed-off-by: Wen Zhou <wenzhou@redhat.com> --------- Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit e7e3982)
* Fix Kserve Unmanaged Installation * Update tests for kserve (cherry picked from commit b467ed7)
Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit bef7e86)
- add clusterrolebinding prometheus-k8s-viewer - add clusterrole prometheus-k8s-viewer - this should be applied for both ODH and downstream - add prometheus folder from config for bundle - cleanup config for parts as duplicated: - tokenreviews - subjectaccessreviews - remove leader_election related rbac, we dont use them - remove dsci rbac fron config, we dont need them - Signed-off-by: Wen Zhou <wenzhou@redhat.com> (cherry picked from commit 6bc16b0)
5f87c78 to
4330b9b
Compare
i had a look at this, dont think it is a problem , more like the one in upstream is called opendatahub-* the one in downstream should be rhods-* / redhat-ods-* cherrypick these 2 commits + rename it bundle: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.