feat: set DSCI application namespace to be immutable (#1222)

- we do not support other values for now, this is to prevent user change to different value and cause old and new both running Signed-off-by: Wen Zhou <wenzhou@redhat.com>
red-hat-data-services · Sep 13, 2024 · ff7d131 · ff7d131
1 parent dd3df21
commit ff7d131
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/apis/dscinitialization/v1/dscinitialization_types.go b/apis/dscinitialization/v1/dscinitialization_types.go
@@ -32,6 +32,7 @@ import (
 type DSCInitializationSpec struct {
 	// Namespace for applications to be installed, non-configurable, default to "opendatahub"
 	// +kubebuilder:default:=opendatahub
+	// +kubebuilder:validation:XValidation:rule="self == oldSelf",message="ApplicationsNamespace is immutable"
 	// +operator-sdk:csv:customresourcedefinitions:type=spec,order=1
 	ApplicationsNamespace string `json:"applicationsNamespace"`
 	// Enable monitoring on specified namespace

diff --git a/bundle/manifests/dscinitialization.opendatahub.io_dscinitializations.yaml b/bundle/manifests/dscinitialization.opendatahub.io_dscinitializations.yaml
@@ -57,6 +57,9 @@ spec:
                 description: Namespace for applications to be installed, non-configurable,
                   default to "opendatahub"
                 type: string
+                x-kubernetes-validations:
+                - message: ApplicationsNamespace is immutable
+                  rule: self == oldSelf
               devFlags:
                 description: |-
                   Internal development useful field to test customizations.

diff --git a/config/crd/bases/dscinitialization.opendatahub.io_dscinitializations.yaml b/config/crd/bases/dscinitialization.opendatahub.io_dscinitializations.yaml
@@ -57,6 +57,9 @@ spec:
                 description: Namespace for applications to be installed, non-configurable,
                   default to "opendatahub"
                 type: string
+                x-kubernetes-validations:
+                - message: ApplicationsNamespace is immutable
+                  rule: self == oldSelf
               devFlags:
                 description: |-
                   Internal development useful field to test customizations.