Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to uninstall odh-nightly from managed cluster #1421

Merged
merged 1 commit into from
May 6, 2024
Merged

Add support to uninstall odh-nightly from managed cluster #1421

merged 1 commit into from
May 6, 2024

Conversation

tarukumar
Copy link
Contributor

No description provided.

@tarukumar tarukumar self-assigned this May 6, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-advanced-security[bot]
github-advanced-security bot found potential problems May 6, 2024
View reviewed changes
ods_ci/tasks/Resources/RHODS_OLM/uninstall/uninstall.robot
${return_code} ${output} Run And Return Rc And Output oc delete namespace ${OPERATOR_NAMESPACE} --ignore-not-found
Verify Project Does Not Exists ${OPERATOR_NAMESPACE}
IF "${OPERATOR_NAMESPACE}" != "openshift-marketplace"
${return_code} ${output} Run And Return Rc And Output oc delete namespace ${OPERATOR_NAMESPACE} --ignore-not-found

Check warning

Code scanning / Robocop

Line is too long ({{ line_length }}/{{ allowed_length }}) Warning

Line is too long (130/120)
ods_ci/tasks/Resources/RHODS_OLM/uninstall/uninstall.robot
@@ -64,13 +64,19 @@

Uninstall RHODS V2
[Documentation] Keyword to uninstall the version 2 of the RHODS operator in Self-Managed
Log To Console message=Deleting DSC CR From Cluster
${return_code} ${output} Run And Return Rc And Output

Check warning

Code scanning / Robocop

Local variable '{{ name }}' is overwritten before usage Warning

Local variable '${return_code}' is overwritten before usage
ods_ci/tasks/Resources/RHODS_OLM/uninstall/uninstall.robot
@@ -64,13 +64,19 @@

Uninstall RHODS V2
[Documentation] Keyword to uninstall the version 2 of the RHODS operator in Self-Managed
Log To Console message=Deleting DSC CR From Cluster
${return_code} ${output} Run And Return Rc And Output

Check warning

Code scanning / Robocop

Local variable '{{ name }}' is overwritten before usage Warning

Local variable '${output}' is overwritten before usage
ods_ci/tasks/Resources/RHODS_OLM/uninstall/uninstall.robot
${return_code} ${output} Run And Return Rc And Output
... oc delete datasciencecluster --all --ignore-not-found
Should Be Equal As Integers ${return_code} 0 msg=Error deleting DataScienceCluster CR
Log To Console message=Deleting DSCi CR From Cluster
${return_code} ${output} Run And Return Rc And Output

Check warning

Code scanning / Robocop

Local variable '{{ name }}' is overwritten before usage Warning

Local variable '${return_code}' is overwritten before usage
ods_ci/tasks/Resources/RHODS_OLM/uninstall/uninstall.robot
${return_code} ${output} Run And Return Rc And Output
... oc delete datasciencecluster --all --ignore-not-found
Should Be Equal As Integers ${return_code} 0 msg=Error deleting DataScienceCluster CR
Log To Console message=Deleting DSCi CR From Cluster
${return_code} ${output} Run And Return Rc And Output

Check warning

Code scanning / Robocop

Local variable '{{ name }}' is overwritten before usage Warning

Local variable '${output}' is overwritten before usage
ods_ci/tasks/Resources/RHODS_OLM/pre-tasks/oc_is_operator_installed.robot
@@ -24,15 +24,23 @@
FAIL Provided test environment and install type combination is not supported
END
ELSE IF "${cluster_type}" == "managed"
Set Global Variable ${SUB_NAME} addon-managed-odh
Set Global Variable ${CATALOG_NAME} addon-managed-odh-catalog

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note

Set Global Variable can be replaced with VAR
ods_ci/tasks/Resources/RHODS_OLM/pre-tasks/oc_is_operator_installed.robot
@@ -24,15 +24,23 @@
FAIL Provided test environment and install type combination is not supported
END
ELSE IF "${cluster_type}" == "managed"
Set Global Variable ${SUB_NAME} addon-managed-odh
Set Global Variable ${CATALOG_NAME} addon-managed-odh-catalog
#For managed cluster

Check warning

Code scanning / Robocop

Missing blank space after comment character Warning

Missing blank space after comment character
ods_ci/tasks/Resources/RHODS_OLM/pre-tasks/oc_is_operator_installed.robot
Set Global Variable ${CATALOG_NAME} addon-managed-odh-catalog
#For managed cluster
IF "${UPDATE_CHANNEL}" == "odh-nightlies"
Set Global Variable ${OPERATOR_NAMESPACE} openshift-marketplace

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note

Set Global Variable can be replaced with VAR
ods_ci/tasks/Resources/RHODS_OLM/pre-tasks/oc_is_operator_installed.robot
#For managed cluster
IF "${UPDATE_CHANNEL}" == "odh-nightlies"
Set Global Variable ${OPERATOR_NAMESPACE} openshift-marketplace
Set Global Variable ${SUB_NAME} rhoai-operator-dev

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note

Set Global Variable can be replaced with VAR
ods_ci/tasks/Resources/RHODS_OLM/pre-tasks/oc_is_operator_installed.robot
IF "${UPDATE_CHANNEL}" == "odh-nightlies"
Set Global Variable ${OPERATOR_NAMESPACE} openshift-marketplace
Set Global Variable ${SUB_NAME} rhoai-operator-dev
Set Global Variable ${CATALOG_NAME} rhoai-catalog-dev

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note

Set Global Variable can be replaced with VAR
@tarukumar tarukumar added verified This PR has been tested with Jenkins enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) labels May 6, 2024
aloganat
aloganat approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@aloganat aloganat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tarukumar tarukumar merged commit c2a17e0 into red-hat-data-services:master May 6, 2024
8 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass %
446 0 0 446 100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloganat aloganat aloganat approved these changes

@mwaykole mwaykole mwaykole approved these changes

Assignees

@tarukumar tarukumar

Labels
enhancements Bugfixes, enhancements, refactoring, ... in tests or libraries (PR will be listed in release-notes) verified This PR has been tested with Jenkins
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarukumar @aloganat @mwaykole