Refine execute_command function for printing aligned tabbed tables
#1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robot Results
|
The commit adds type hints to parameters and return type of the `execute_command` function in util.py script. It also introduces a change in printing logic to handle tabs. Further, new test cases are added in test_util.py script to confirm this behavior. ### Before ``` 10:31:54 >: Cluster Admin: true 10:31:54 >: Organization: N/A 10:31:54 >: Creator: N/A 10:31:54 >: Email: N/A 10:31:54 >: AccountNumber: N/A 10:31:54 >: Created: 2024-04-12T08:31:54Z 10:31:54 >: Expiration: 2024-04-13T20:31:53Z ``` ### After ``` 20:02:16 >: Cluster Admin: true 20:02:16 >: Organization: N/A 20:02:16 >: Creator: N/A 20:02:16 >: Email: N/A 20:02:16 >: AccountNumber: N/A 20:02:16 >: Created: 2024-04-12T18:02:16Z 20:02:16 >: Expiration: 2024-04-14T06:02:15Z ``` Signed-off-by: Jiri Daněk <jdanek@redhat.com>
|
|
msg-qe-11 .xxx. /job/rhods/job/rhods-smoke/5/console |
jstourac
approved these changes
Apr 14, 2024
bdattoma
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit adds type hints to parameters and return type of the
execute_commandfunction in util.py script. It also introduces a change in printing logic to handle tabs. Further, new test cases are added in test_util.py script to confirm this behavior.Before
After