Add Provisioning ability for IBM Cloud Self-managed #1335
Conversation
There was a problem hiding this comment.
Robocop found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Robot Results
|
|
Other cloud providers regression testing provisioning/deprovisionin:
Provision IBM Cloud: PASSED Cannot test on CI yet because of missing pkgs - support will be added later Deprovision IBM Cloud: PASSED |
| IF ${use_cluster_pool} | ||
| ${pool_namespace} = Get Cluster Pool Namespace ${pool_name} | ||
| Set Task Variable ${pool_namespace} | ||
| Set Task Variable ${clusterdeployment_name} ${pool_namespace} |
There was a problem hiding this comment.
@bdattoma FYI:
- The Cluster deployment name has a similar name (if I recall) as the cluster pool namespace by default.
- The Cluster pool namespace is a unique name, which includes the cluster name prefix.
- We should not make the cluster name equal to cluster pool namespace (which is currently the case for GCP and AWS).
There was a problem hiding this comment.
I just replicated the logic that was there earlier.
The code was using ${pool_namespace} variable as cluster deployment name when using cluster pools. see https://github.com/red-hat-data-services/ods-ci/pull/1335/files/a4dfb8d020042819202abf826e342ddcdc1649a5#diff-069081f68a5b54944843728104321c2a7f2d596f186734b832ddf7d8265185b7L159
ods_ci/tasks/Resources/Provisioning/Hive/IBM/ibmcloud-cluster.yaml
Outdated
Show resolved
Hide resolved
|
|
extending the provisionin/deprovisioning tasks to work with IBM Cloud