Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick from odh-deploy for ConfigMap #439

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Cherry-pick from odh-deploy for ConfigMap #439

merged 1 commit into from
Jul 31, 2023

Conversation

zdtsw
Copy link

@zdtsw zdtsw commented Jul 28, 2023

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • For commits that came from upstream, [UPSTREAM] has been prepended to the commit message
  • JIRA link(s):
  • The Jira story is acked
  • An entry has been added to the latest build document in Build Announcements Folder.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious)

Cherry-pick from https://github.com/red-hat-data-services/odh-deployer/blob/main/odh-dashboard/configs/odh-enabled-applications-config.configmap.yaml

@zdtsw zdtsw requested review from lucferbux and VaishnaviHire July 28, 2023 14:25
@zdtsw zdtsw changed the base branch from master to feature-rearchitecture July 28, 2023 14:25
VaishnaviHire
VaishnaviHire approved these changes Jul 28, 2023
View reviewed changes
Copy link

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zdtsw zdtsw changed the base branch from feature-rearchitecture to master July 28, 2023 14:27
@zdtsw
Add ConfigMap for Jupyter UI in notebook-controller
8ab80b9 
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw force-pushed the feat/dashboard_cm branch 2 times, most recently from 00c1304 to 8ab80b9 Compare July 28, 2023 14:34
VaishnaviHire
VaishnaviHire approved these changes Jul 28, 2023
View reviewed changes
Copy link

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zdtsw
Copy link
Author

zdtsw commented Jul 28, 2023

@lucferbux need a review on this one

lucferbux
lucferbux approved these changes Jul 31, 2023
View reviewed changes
Copy link

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@anishasthana anishasthana merged commit 75d049c into red-hat-data-services:master Jul 31, 2023
@VaishnaviHire VaishnaviHire mentioned this pull request Aug 4, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaishnaviHire VaishnaviHire VaishnaviHire approved these changes

@lucferbux lucferbux lucferbux approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zdtsw @lucferbux @VaishnaviHire @anishasthana