Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enablement of Partner Managed ISVs #52

Merged

Conversation

jeff-phillips-18
Copy link

@jeff-phillips-18 jeff-phillips-18 commented Apr 20, 2021

@jeff-phillips-18 jeff-phillips-18 changed the title (WIP) Add enablement of Partner Managed ISVs Add enablement of Partner Managed ISVs Apr 20, 2021
Copy link

@crobby crobby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen these changes work, lgtm

Copy link

@cdcabrera cdcabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, optional minor confirmation on your side

return axios
.get(url, options)
.then((response) => {
return response;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional: confirmation on your end, since the other API calls all use response.data ... though it doesn't appear you're doing anything with the response other than checking "success"

@jeff-phillips-18 jeff-phillips-18 merged commit 4ce1fb0 into red-hat-data-services:master Apr 20, 2021
crobby pushed a commit to crobby/odh-dashboard that referenced this pull request Apr 22, 2021
* Add enablement of Partner Managed ISVs

* update permissions for dev installed user
kkasravi pushed a commit to kkasravi/odh-dashboard that referenced this pull request Jun 7, 2021
…ld-notifications

Watch notebook images install status
@jeff-phillips-18 jeff-phillips-18 deleted the enable-apps branch November 12, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants