-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enablement of Partner Managed ISVs #52
Add enablement of Partner Managed ISVs #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen these changes work, lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, optional minor confirmation on your side
return axios | ||
.get(url, options) | ||
.then((response) => { | ||
return response; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional: confirmation on your end, since the other API calls all use response.data
... though it doesn't appear you're doing anything with the response other than checking "success"
* Add enablement of Partner Managed ISVs * update permissions for dev installed user
…ld-notifications Watch notebook images install status
Fixes: https://issues.redhat.com/browse/RHODS-400