Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken flyway download and install #32

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Fixed broken flyway download and install #32

merged 3 commits into from
Jan 28, 2025

Conversation

Peter-Laws
Copy link
Contributor

@Peter-Laws Peter-Laws commented Jan 27, 2025

The recent documentation move broke the flyway version evaluation of the 'Flyway_DownloadAndInstallCLI.ps1' & 'Flyway_DownloadAndInstallCLI_Unix.sh' scripts, meaning the download target couldn't be resolved.

A more robust version checker would be the preferable longer term solution, but this restores the original functionality.

@csnhawkins
Copy link
Contributor

Thanks for the PR Peter! The two scripts were updated a couple weeks ago actually, after the links became broken. Which moved to this link:

However, I was afraid they may move again. So your link seems interesting, but for me is just broken. https://documentation.red-gate.com/flyway/reference/usage/command-line.html

Do you know why that would be? As i'd love to have a link without the number suffix.

@Peter-Laws
Copy link
Contributor Author

My apologies, the customer who reported it didn't have a recent pull.

For the links, find and replace fail on my part, sorry, the suffix shouldn't be there, corrected and tested locally. Would appreciate a review once the latest checks have cleared.

@csnhawkins
Copy link
Contributor

That link seems much better and a very nice and welcome change, so thanks for that. Should be more bullet proof.

Although I only used that page as it was tricky to make the normal downloads location work in PS or BASH. So perhaps we can improve this further, but not urgent now.

Approving your PR!

@csnhawkins csnhawkins merged commit eb6b1bc into main Jan 28, 2025
1 check failed
@csnhawkins csnhawkins deleted the patch_urlMove branch January 28, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants