Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/RZA-250001: abcd copied from xkeshav/abcd #3

Merged
merged 7 commits into from
Jan 18, 2025
Merged

feature/RZA-250001: abcd copied from xkeshav/abcd #3

merged 7 commits into from
Jan 18, 2025

Conversation

Ciphrox
Copy link
Collaborator

@Ciphrox Ciphrox commented Jan 11, 2025 •
edited
Loading

Added Abcd

  • Copied the main pages from xkeshav:abcd with proper css while following the template
  • added a sample.astro as a template

Fixes # (issue)
#1

Image References

Open

image
image
image

@Ciphrox
xkeshav:abcd copied
4a9111a 
- Copied the main pages from xkeshav:abcd with proper css while following the template
- added a sample.astro as a template
@recursivezero recursivezero linked an issue Jan 12, 2025 that may be closed by this pull request
❇️ RZA-250001: code conversion in Astro #1
Closed
@Ciphrox Ciphrox changed the title xkeshav:abcd copied feature/RZA-250001: abcd copied from xkeshav/abcd Jan 12, 2025
@recursivezero
Copy link
Owner

recursivezero commented Jan 13, 2025 •
edited
Loading

  1. Top bar on page must be align with the UI ;currently look very vague.

  2. There are 2 files globals.css and global.css use only once; remove duplicate style

  3. custom fonts style will be moved to fonts.css file and import in globals.css

image

@Ciphrox
Copy link
Collaborator Author

Ciphrox commented Jan 14, 2025

  1. Top bar on page must be align with the UI ;currently look very vague.

which top bar are you referring to

@xkeshav xkeshav changed the base branch from main to develop January 18, 2025 14:23
@xkeshav xkeshav merged commit 093df22 into develop Jan 18, 2025
3 checks passed
@Ciphrox Ciphrox deleted the feature/RZA-250001 branch February 26, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@recursivezero recursivezero Awaiting requested review from recursivezero recursivezero is a code owner

@xkeshav xkeshav Awaiting requested review from xkeshav xkeshav is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

❇️ RZA-250001: code conversion in Astro
3 participants
@Ciphrox @recursivezero @xkeshav