Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 7.1 Scoped] install dev dependency as well to allow run phpunit #5561

Merged
merged 2 commits into from
Feb 15, 2021

Conversation

samsonasik
Copy link
Member

No description provided.

@samsonasik samsonasik enabled auto-merge (squash) February 15, 2021 18:44
@samsonasik samsonasik merged commit 4fa3573 into master Feb 15, 2021
@samsonasik samsonasik deleted the install-dev-dependency-aswell branch February 15, 2021 18:51
@samsonasik
Copy link
Member Author

running on root rector-php71 with dev dependency installed got the following error:

➜  rector-php71 git:(master) vendor/bin/phpunit 
This version of PHPUnit requires PHP >= 7.3.
You are using PHP 7.1.33 (/opt/homebrew/Cellar/php@7.1/7.1.33/bin/php).

The php version on build php 7.1 seems need to have php 7.1 as well.

@TomasVotruba
Copy link
Member

Here the wget PHPUnit for PHP 7.1+ must be used.

The PHPUnit 7 is the only one that works on PHP 7.1: https://phpunit.de/getting-started/phpunit-7.html

TomasVotruba added a commit that referenced this pull request Feb 5, 2024
rectorphp/rector-src@c44e1e5 Real fix paths The given paths do not match any files on RectorConfigBuilder (#5561)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants