Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not prefix Symplify\ComposerJsonManipulator\ValueObject\ComposerJson? #6405

Closed
sabbelasichon opened this issue May 11, 2021 · 2 comments · Fixed by rectorphp/rector-src#17
Closed

Do not prefix Symplify\ComposerJsonManipulator\ValueObject\ComposerJson? #6405

sabbelasichon opened this issue May 11, 2021 · 2 comments · Fixed by rectorphp/rector-src#17
Labels
bug

Comments

@sabbelasichon
Copy link
Contributor

The class Symplify\ComposerJsonManipulator\ValueObject\ComposerJson is part of the public API of Rector because it is required by the ComposerRectorInterface. I think it should not be prefixed.
@TomasVotruba
Copy link
Member

Agreed 👍 could you send PR?

sabbelasichon added a commit to sabbelasichon/rector-src that referenced this issue May 11, 2021
@sabbelasichon
[TASK] Do not prefix class ComposerJson
49431b7 
Resolves: rectorphp/rector#6405
@sabbelasichon sabbelasichon mentioned this issue May 11, 2021
Merged
@samsonasik samsonasik mentioned this issue May 11, 2021
Merged
1 task
sabbelasichon added a commit to sabbelasichon/rector-src that referenced this issue May 11, 2021
@sabbelasichon
[TASK] Do not prefix class ComposerJson
019983b 
Resolves: rectorphp/rector#6405
sabbelasichon added a commit to sabbelasichon/rector-src that referenced this issue May 11, 2021
@sabbelasichon
[TASK] Do not prefix class ComposerJson
b626cdc 
Resolves: rectorphp/rector#6405
TomasVotruba pushed a commit to rectorphp/rector-src that referenced this issue May 11, 2021
@sabbelasichon
[TASK] Do not prefix class ComposerJson (#17)
70ef6eb 
Resolves: rectorphp/rector#6405
@sabbelasichon
Copy link
Contributor Author

As we are trying to create a standalone package for TYPO3 Rector we have noticed that the ComposerJson class is scoped: https://github.com/rectorphp/rector/blob/main/vendor/symplify/composer-json-manipulator/src/ValueObject/ComposerJson.php.

I will create a PR which tries to prevent the scoping of this class.

sabbelasichon added a commit to sabbelasichon/rector-src that referenced this issue Jun 28, 2022
@sabbelasichon
TASK: Do not prefix ComposerJson class
c61c547 
Resolves: rectorphp/rector#6405
@sabbelasichon sabbelasichon mentioned this issue Jun 28, 2022
Closed
TomasVotruba added a commit that referenced this issue Nov 4, 2024
@TomasVotruba
Updated Rector to commit f7ea3dbfeb4e02ab42442dd9e90283e8af098e4f
4261346 
rectorphp/rector-src@f7ea3db [PHP8.3] add new rectors for get_class()/get_parent_class() without arguments (#6405)
carlos-granados added a commit to carlos-granados/rector that referenced this issue Nov 13, 2024
@carlos-granados
Updated Rector to commit fb3c33aec495946d0bd1b9422b9b65f44665defd
1556d66 
carlos-granados/rector-src@f7ea3db [PHP8.3] add new rectors for get_class()/get_parent_class() without arguments (rectorphp#6405)
carlos-granados/rector-src@1afc647 Rectify (rectorphp#6408)
carlos-granados/rector-src@afe7c46 [DeadCode] Skip nullable @ template on RemoveUselessReturnTagRector (rectorphp#6409)
carlos-granados/rector-src@293eb97 [Php81] Skip Doctrine Embeddable on ReadOnlyPropertyRector (rectorphp#6411)
carlos-granados/rector-src@1b1807b [Privatization] Skip with parameter on PrivatizeLocalGetterToPropertyRector (rectorphp#6412)
carlos-granados/rector-src@2c67908 Fix ClassDependencyManipulator to add dependency on right position (rectorphp#6413)
carlos-granados/rector-src@29e8932 [automated] Apply Coding Standard (rectorphp#6414)
carlos-granados/rector-src@3949fc2 Move instanceof PHPStan Type to ->is*() take 1 (rectorphp#6416)
carlos-granados/rector-src@0cac71a [CodeQuality] Add fixture test for skip nullable array from property with default value (rectorphp#6417)
carlos-granados/rector-src@d2db35e [Php80] Returns null on no change on ClassPropertyAssignToConstructorPromotionRector (rectorphp#6418)
carlos-granados/rector-src@06adce3 use ->isInteger()->yes() on ReturnTypeFromStrictNewArrayRector (rectorphp#6419)
carlos-granados/rector-src@bcfb598 Add ClassNameFromObjectTypeResolver to cover TypeWithClassName instance checks (rectorphp#6420)
carlos-granados/rector-src@84bb596 [StaticTypeMapper] Reduce instanceof TypeWithClassName usage via ClassNameFromObjectTypeResolver (rectorphp#6421)
carlos-granados/rector-src@26b8b54 [Naming] Reduce instanceof ObjectType on ExpectedNameResolver (take 5) (rectorphp#6423)
carlos-granados/rector-src@5baf487 Require-dev phpstan/phpstan-deprecation-rules to show list of deprecated (rectorphp#6415)
carlos-granados/rector-src@c23ba82 [deprecation] Remove deprecated PublicConstantVisibilityRector, cleanup deprecated SetListInterface (rectorphp#6424)
carlos-granados/rector-src@c2053c7 [deprecation] Deprecate AbstractScopeAwareRector in favor of single AbstractRector (rectorphp#6425)
carlos-granados/rector-src@2c5cd97 [deprecated] Remove deprecated AbstractTestCase (rectorphp#6426)
carlos-granados/rector-src@fb3c33a Merge commit '2c5cd97a3a98ab5af9efb846f6f78738e4a195a6'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
2 participants
@TomasVotruba @sabbelasichon