Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation about FileProcessors #6374

Closed
sabbelasichon opened this issue May 6, 2021 · 8 comments · Fixed by rectorphp/rector-src#121
Closed

Documentation about FileProcessors #6374

sabbelasichon opened this issue May 6, 2021 · 8 comments · Fixed by rectorphp/rector-src#121
Assignees
Labels

Comments

@sabbelasichon
Copy link
Contributor

I would like to document, as promised, the new FileProcessors API.

@lulco:
Would you like to join me?
I would like to talk about the FileProcessors and the FileFormatters together because this seem somehow interconnected.

@lulco
Copy link
Contributor

lulco commented May 6, 2021

Yes!
But first I have to learn how it works now and finish this PR efabrica-team/rector-nette#7 :)

@TomasVotruba
Copy link
Member

TomasVotruba commented May 14, 2021

Just checking :) What blockers are there to move this forward?

@sabbelasichon
Copy link
Contributor Author

None.

@sabbelasichon
Copy link
Contributor Author

At least for me. Lacking of time ;-)

@sabbelasichon sabbelasichon self-assigned this May 18, 2021
@lulco
Copy link
Contributor

lulco commented May 25, 2021

Few notes from me after working on some nette non-php file processors. {Type} can be some file type:

  • we need some {Type}RectorInterface which extends RectorInterface (here we can add some methods to change content)
  • implement some services of {Type}RectorInterface which do their work (they change content of supported files)
  • than we need some {Type}FileProcessor which implements FileProcessorInterface (as parameter in constructor, there is an array of {Type}RectorInterface). It just iterate all supported files and apply all {Type}Rectors

But that's obvious, right? :D

@sabbelasichon
Copy link
Contributor Author

@lulco Thanks. Sound good. Yes, for you and me it is obvious, but not for others, so you added already good points to start with from a beginners perspective. Would you be able to start a PR with some notes and i try to add or comment on it?

@lulco
Copy link
Contributor

lulco commented May 26, 2021

I'm not very comfortable with writing documentation O:-) that's why I wrote those notes for you :)

@sabbelasichon
Copy link
Contributor Author

I am on it.

sabbelasichon added a commit to sabbelasichon/rector-src that referenced this issue May 28, 2021
sabbelasichon added a commit to rectorphp/rector-src that referenced this issue Jun 5, 2021
TomasVotruba pushed a commit to rectorphp/rector-src that referenced this issue Jun 13, 2021
* [TASK] Add documentation about FileProcessors

Resolves: rectorphp/rector#6374

* [TASK] Change some things
TomasVotruba added a commit that referenced this issue Oct 11, 2024
rectorphp/rector-src@d553e84 [StaticTypeMapper] Register non-empty-array to ScalarStringToTypeMapper::SCALAR_NAME_BY_TYPE constant (#6374)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants