Skip to content

Commit

Permalink
Updated Rector to commit 41729c25cb33ec5219433d5e101d6d54ed4045a2
Browse files Browse the repository at this point in the history
rectorphp/rector-src@41729c2 [DeadCode] Skip @return never with void on  RemoveUselessReturnTagRector (#5320)
  • Loading branch information
TomasVotruba committed Dec 4, 2023
1 parent d9834a6 commit ee373e6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion rules/DeadCode/PhpDoc/DeadReturnTagValueNodeAnalyzer.php
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ public function isDead(ReturnTagValueNode $returnTagValueNode, ClassMethod $clas
}
// in case of void, there is no added value in @return tag
if ($returnType instanceof Identifier && $returnType->toString() === 'void') {
return \true;
return !$returnTagValueNode->type instanceof IdentifierTypeNode || (string) $returnTagValueNode->type !== 'never';
}
if (!$this->typeComparator->arePhpParserAndPhpStanPhpDocTypesEqual($returnType, $returnTagValueNode->type, $classMethod)) {
return $returnTagValueNode->type instanceof IdentifierTypeNode && (string) $returnTagValueNode->type === 'void';
Expand Down
4 changes: 2 additions & 2 deletions src/Application/VersionResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@ final class VersionResolver
* @api
* @var string
*/
public const PACKAGE_VERSION = '8e6d46a58fff8e6bd5276b9ae473bfb91460b487';
public const PACKAGE_VERSION = '41729c25cb33ec5219433d5e101d6d54ed4045a2';
/**
* @api
* @var string
*/
public const RELEASE_DATE = '2023-12-03 20:10:35';
public const RELEASE_DATE = '2023-12-04 08:54:10';
/**
* @var int
*/
Expand Down

0 comments on commit ee373e6

Please sign in to comment.