[test-autoload] Trigger preload only in case of old php-parser to avoid double php-parser crash

[TomasVotruba]

cc @peterfox

[peterfox]

Working for me now 👍

[samsonasik]

/cc @nikophil @staabm @markstory FYI

ensure verify this effect by remove this manual require in phpunit bootstrap

-require dirname(__DIR__) . '/vendor/rector/rector/preload.php';

line require to avoid conflict by test dev-main or next release, see the previous usage on cakephp upgrade:

https://github.com/cakephp/upgrade/blob/0f84083e7fa59315c5a37c8c38632d4670bd1001/tests/bootstrap.php#L14

[staabm]

I wonder why a 3rd party test-suite is/should including the rector preload.php at phpunit bootstrap phase?

[samsonasik]

@staabm the preload is needed to ensure testing rector custom rule working to work with php-parser 5 over 4, which seems some conflict with some phpunit dependency which still on php-parser 4

[samsonasik]

@staabm manual require should not longer needed, but may need removal of manual require if it was added in custom rules to avoid double require.

[TomasVotruba]

@peterfox Could you share a bit more of your issue that you wrote me directly, so we have more context here for other readers?

[samsonasik]

Ref the original issue

• Testing Rector rules and PHPStan rules in the same test suite rector#8975
• https://github.com/cakephp/upgrade/actions/runs/11949020831/job/33307638870

that was require manual include rector preload, see

cakephp/upgrade@5b896c1#diff-96a82592013e5f4b91e682332583b7a4a6ca1ff0431d267c61179b1a21b167da

Yes, moving require means need to be verified to remove the previous manual require preload it in community rules, ensuring no double require that may cause another "the name is already in use" issue.