Upgrade deprecated set-* #3013
Merged
Upgrade deprecated set-* #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
approved these changes
Oct 24, 2022
|
Thank you @rez1dent3 |
|
Ref for escaping issue that may need update after updating phpstan-src workflow today: phpstan/phpstan-src#1910 @rez1dent3 could you verify if something needs update for it? Thank you |
|
@rez1dent3 I just re-started the scoped build and it seems still working ok https://github.com/rectorphp/rector-src/actions/runs/3314844962/jobs/5489279164 |
|
@samsonasik This is good. But there are special characters that need to be escaped. Apparently these special characters are not used in the rector. And here with phpstan an ambush, of course. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes rectorphp/rector#7555