Merge pull request #1152 from duncanmcclean/explicit-nullable-param-d…

…eclarations Fixes for implicit nullability deprecation
rebing · Nov 22, 2024 · 79da816 · 79da816
2 parents 6caf374 + 65d9a0c
commit 79da816
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 10 deletions.
diff --git a/src/GraphQL.php b/src/GraphQL.php
@@ -227,7 +227,7 @@ public function addTypes(array $types): void
     /**
      * @param object|string $class
      */
-    public function addType($class, string $name = null): void
+    public function addType($class, ?string $name = null): void
     {
         if (!$name) {
             $type = \is_object($class) ? $class : $this->app->make($class);
@@ -487,7 +487,7 @@ protected function clearTypeInstances(): void
         $this->typesInstances = [];
     }
 
-    public function paginate(string $typeName, string $customName = null): Type
+    public function paginate(string $typeName, ?string $customName = null): Type
     {
         $name = $customName ?: $typeName . 'Pagination';
 
@@ -499,7 +499,7 @@ public function paginate(string $typeName, string $customName = null): Type
         return $this->typesInstances[$name];
     }
 
-    public function simplePaginate(string $typeName, string $customName = null): Type
+    public function simplePaginate(string $typeName, ?string $customName = null): Type
     {
         $name = $customName ?: $typeName . 'SimplePagination';
 

diff --git a/src/Support/Field.php b/src/Support/Field.php
@@ -34,7 +34,7 @@ abstract class Field
      * @param mixed $root
      * @param mixed $ctx
      */
-    public function authorize($root, array $args, $ctx, ResolveInfo $resolveInfo = null, Closure $getSelectFields = null): bool
+    public function authorize($root, array $args, $ctx, ?ResolveInfo $resolveInfo = null, ?Closure $getSelectFields = null): bool
     {
         return true;
     }

diff --git a/src/Support/PaginationType.php b/src/Support/PaginationType.php
@@ -11,7 +11,7 @@
 
 class PaginationType extends ObjectType
 {
-    public function __construct(string $typeName, string $customName = null)
+    public function __construct(string $typeName, ?string $customName = null)
     {
         $name = $customName ?: $typeName . 'Pagination';
 

diff --git a/src/Support/SimplePaginationType.php b/src/Support/SimplePaginationType.php
@@ -11,7 +11,7 @@
 
 class SimplePaginationType extends ObjectType
 {
-    public function __construct(string $typeName, string $customName = null)
+    public function __construct(string $typeName, ?string $customName = null)
     {
         $name = $customName ?: $typeName . 'SimplePagination';
 

diff --git a/tests/Support/Objects/ExamplesAuthorizeMessageQuery.php b/tests/Support/Objects/ExamplesAuthorizeMessageQuery.php
@@ -15,7 +15,7 @@ class ExamplesAuthorizeMessageQuery extends Query
         'name' => 'Examples authorize query',
     ];
 
-    public function authorize($root, array $args, $ctx, ResolveInfo $resolveInfo = null, Closure $getSelectFields = null): bool
+    public function authorize($root, array $args, $ctx, ?ResolveInfo $resolveInfo = null, ?Closure $getSelectFields = null): bool
     {
         return false;
     }

diff --git a/tests/Support/Objects/ExamplesAuthorizeQuery.php b/tests/Support/Objects/ExamplesAuthorizeQuery.php
@@ -15,7 +15,7 @@ class ExamplesAuthorizeQuery extends Query
         'name' => 'Examples authorize query',
     ];
 
-    public function authorize($root, array $args, $ctx, ResolveInfo $resolveInfo = null, Closure $getSelectFields = null): bool
+    public function authorize($root, array $args, $ctx, ?ResolveInfo $resolveInfo = null, ?Closure $getSelectFields = null): bool
     {
         return false;
     }

diff --git a/tests/Support/Traits/MakeCommandAssertionTrait.php b/tests/Support/Traits/MakeCommandAssertionTrait.php
@@ -18,7 +18,7 @@ protected function assertMakeCommand(
         string $expectedFilename,
         string $expectedNamespace,
         string $expectedClassDefinition,
-        string $expectedGraphqlName = null
+        ?string $expectedGraphqlName = null
     ): void {
         $filesystemMock = $this
             ->getMockBuilder(Filesystem::class)

diff --git a/tests/Unit/ValidationAuthorizationTests/ValidationAndAuthorizationMutation.php b/tests/Unit/ValidationAuthorizationTests/ValidationAndAuthorizationMutation.php
@@ -14,7 +14,7 @@ class ValidationAndAuthorizationMutation extends Mutation
         'name' => 'validationAndAuthorization',
     ];
 
-    public function authorize($root, array $args, $ctx, ResolveInfo $resolveInfo = null, Closure $getSelectFields = null): bool
+    public function authorize($root, array $args, $ctx, ?ResolveInfo $resolveInfo = null, ?Closure $getSelectFields = null): bool
     {
         return 'value1' === $args['arg1'];
     }