Running monkey on release variant to detect any Proguard misconfiguration #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 19, 2022 19:06
…library-base proguard consumer file as they are needed when instantiating JNI's JavaClassGlobalDef. Additionally added a step to CI where the monkey runner is executed on the release sample app instead of the debug one.
nhachicha
reviewed
Jan 20, 2022
| kotlinx.serialization.KSerializer serializer(...); | ||
| } | ||
|
|
||
| # Change here com.yourcompany.yourpackage |
There was a problem hiding this comment.
The rules below were accidentally copied from the Bookshelf app
🤦 that's right. I've already changed it. It will hopefully be fine on CI, since I ran it like 10 times on my machine yesterday. |
cmelchior
approved these changes
Jan 20, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #643
Moved Proguard sync-related exceptions located under
cinteropto thelibrary-baseProguard consumer file as they are needed when instantiating JVM'sJavaClassGlobalDef.Added missing exceptions for
RealmObjectCompanionandJVMScheduleras well since it was also causing similar crashes.Added a step to CI where the monkey runner is executed on the release sample app instead of the debug one to catch these types of Proguard issues.